Closed Bug 1733177 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30894 - Rename InterestGroup API flag for common use and add flag for PARAKEET impl

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox95 fixed)

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30894 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30894
Details from upstream follow.

Brandon Maslen <brandm@microsoft.com> wrote:

Rename InterestGroup API flag for common use and add flag for PARAKEET impl

Update the FledgeInterestGroupAPI flag/policy to be a more generic
AdInterestGroupAPI for shared usage between multiple ad serving features.

Updates the FledgeInterestGroups flag for backend storage to be
a more generic 'InterestGroupStorage'.

Also splits the specific ad serving API methods under two new runtime
flags 'Fledge', blink::features::kFledge, and 'Parakeet',
blink::features::kParakeet. For PARAKEET the method stubs have been
added but will be fully fleshed out with proper types in a subsequent
change.

Test collateral has been updated to ensure the new surface area is
available and callable.

Bug: 1249186
Change-Id: I1df37b34d73148536a798c13bd279d8316759444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3158266
Commit-Queue: Brandon Maslen \<brandm@microsoft.com>
Reviewed-by: Mike West \<mkwst@chromium.org>
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: Reilly Grant \<reillyg@chromium.org>
Reviewed-by: Matt Falkenhagen \<falken@chromium.org>
Reviewed-by: Maksim Orlovich \<morlovich@chromium.org>
Reviewed-by: Russ Hamilton \<behamilton@google.com>
Cr-Commit-Position: refs/heads/main@{#925398}

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 16 subtests

Status Summary

Firefox

OK : 3
PASS: 12
FAIL: 8

Chrome

OK : 3
PASS: 12
FAIL: 8

Safari

OK : 3
PASS: 12
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/parakeet/createAdRequest.tentative.https.window.html
createAdRequest() should be supported on the navigator interface.: FAIL (Chrome: FAIL, Safari: FAIL)
createAdRequest() should reject with NotSupported initially.: FAIL (Chrome: FAIL, Safari: FAIL)
/parakeet/finalizeAd.tentative.https.window.html
finalizeAd() should be supported on the navigator interface.: FAIL (Chrome: FAIL, Safari: FAIL)
finalizeAd() should reject with NotSupported initially.: FAIL (Chrome: FAIL, Safari: FAIL)
/parakeet/idlharness.tentative.https.window.html
Navigator interface: operation createAdRequest(): FAIL (Chrome: FAIL, Safari: FAIL)
Navigator interface: operation finalizeAd(): FAIL (Chrome: FAIL, Safari: FAIL)
Navigator interface: navigator must inherit property "createAdRequest()" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)
Navigator interface: navigator must inherit property "finalizeAd()" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b623601c70e6 [wpt PR 30894] - Rename InterestGroup API flag for common use and add flag for PARAKEET impl, a=testonly https://hg.mozilla.org/integration/autoland/rev/59a25cb9cd7b [wpt PR 30894] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.