Closed Bug 1733199 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30985 - Style: Remove AppliedTextDecoration declared at display:contents elements

Categories

(Core :: Layout: Text and Fonts, task, P4)

Product:
Core
Component:
Layout: Text and Fonts
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30985 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30985
Details from upstream follow.

Kent Tamura <tkent@chromium.org> wrote:

Style: Remove AppliedTextDecoration declared at display:contents elements

Text decorations declared at display:contents elements should be
ignored.

  • StyleAdjuster::AdjustComputedStyle():
    Copy AppliedTextDecoration instances from |layout_parent_style|
    instead of |parent_style|.
    This change is for elements which are children of a display:contents
    element.

  • StyleResolver::CreateInheritedDisplayContentsStyleIfNeeded():
    Drop AppliedTextDecoration declared at |parent_style|.
    This change is for |Text| node wrappers which are children of a
    display:contents element.

  • LayoutTreeBuilderForText::CreateLayoutObject():
    Text should have a ComputedStyle same as its wrapper.
    This change is for |Text| node which are children of a
    display:contents element.

The new behavior matches to Firefox and Safari.

Bug: 1252619, 1253243
Change-Id: I66bdbd61b2f4f6ea668d81c6a882f65113d74b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3187550
Auto-Submit: Kent Tamura \<tkent@chromium.org>
Commit-Queue: Rune Lillesveen \<futhark@chromium.org>
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#925670}

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4cd9318643c1
[wpt PR 30985] - Style: Remove AppliedTextDecoration declared at display:contents elements, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4cd9318643c1

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.