Closed Bug 1733349 Opened 10 months ago Closed 10 months ago

Assert string spans are null-terminated when passed to ICU

Categories

(Core :: Internationalization, task, P3)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox94 --- wontfix
firefox95 --- fixed

People

(Reporter: anba, Assigned: anba)

References

Details

(Whiteboard: [i18n-unification] )

Attachments

(1 file)

No description provided.

Some functions are accepting Span<const char> and expect that the underlying
const char* is null-terminated. Add an assertion that the string is really
null-terminated before passing it to ICU.

And then fix-up any issues where the string span is including the null
terminator. Also see bug 1660161.

Whiteboard: [i18n-unification]
Priority: -- → P4
Pushed by andre.bargull@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c3e08d3d8c2f
Assert Spans are null-terminated when passed as `const char*` to ICU. r=platform-i18n-reviewers,gregtatum
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Priority: P4 → P3
You need to log in before you can comment on or make changes to this bug.