1733349 - Assert string spans are null-terminated when passed to ICU

Status: RESOLVED FIXED

(Core :: Internationalization, task, P3)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1733349: Assert Spans are null-terminated when passed as `const char*` to ICU. r=#platform-i18n-reviewers!

Some functions are accepting Span<const char> and expect that the underlying
const char* is null-terminated. Add an assertion that the string is really
null-terminated before passing it to ICU.

And then fix-up any issues where the string span is including the null
terminator. Also see bug 1660161.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3e08d3d8c2f
Assert Spans are null-terminated when passed as `const char*` to ICU. r=platform-i18n-reviewers,gregtatum

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/c3e08d3d8c2f