1733356 - [meta] Fix non-unified build errors in netwerk/

Status: RESOLVED FIXED

(Core :: Networking, task, P3)

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1733356 - Fix non-unified build errors in netwerk/dns/ r=#necko

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1733356 - Fix non-unified build errors in netwerk/cache/ r=#necko

Depends on D127399

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1733356 - Fix non-unified build errors in netwerk/cookie/ r=#necko

Depends on D127400

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1733356 - Fix non-unified build errors in netwerk/ipc/ r=#necko

Depends on D127401

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1733356 - Fix non-unified build errors in netwerk/protocol/about/ r=#necko

Depends on D127402

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1733356 - Fix non-unified build errors in netwerk/protocol/gio r=#necko

Depends on D127403

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1733356 - Fix non-unified build errors in netwerk/protocol/res/ r=#necko

Depends on D127404

Comment 8

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1733356 - Fix non-unified build errors in netwerk/protocol/websocket/ r=#necko

Depends on D127405

Comment 9

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1733356 - Fix non-unified build errors in netwerk/protocol/http/ r=#necko

Depends on D127406

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b87b34fa8a6f
Fix non-unified build errors in netwerk/dns/ r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/f1866e615f08
Fix non-unified build errors in netwerk/cache/ r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/e94611929d92
Fix non-unified build errors in netwerk/cookie/ r=necko-reviewers,dragana

Comment 11

[Noemi Erli[:noemi_erli]]

Backed out 3 changesets (Bug 1733356) for causing bustages in CookieStorage.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=JPrl3j4RSxKvofsH6a1BNA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=e94611929d92768872ee15dd04f030580d269b21&searchStr=hybrid

Log: https://treeherder.mozilla.org/logviewer?job_id=353683002&repo=autoland&lineNumber=44976

Backout: https://hg.mozilla.org/integration/autoland/rev/04a3446f3ae37f371aa015ca86720352e57bd442

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c26481d0f689
Fix non-unified build errors in netwerk/dns/ r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/4e198c3d5ef3
Fix non-unified build errors in netwerk/cache/ r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/7700cd82bdf2
Fix non-unified build errors in netwerk/cookie/ r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/14563275a25b
Fix non-unified build errors in netwerk/ipc/ r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/366e2d375980
Fix non-unified build errors in netwerk/protocol/about/ r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/ef8145f88447
Fix non-unified build errors in netwerk/protocol/gio r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/cd6c19829601
Fix non-unified build errors in netwerk/protocol/res/ r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/d2e3dc1b492a
Fix non-unified build errors in netwerk/protocol/websocket/ r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/b640749ee844
Fix non-unified build errors in netwerk/protocol/http/ r=necko-reviewers,kershaw

Comment 13

[Cristian Tuns]

Backed out for causing hybrid build bustages on nsAboutProtocolHandler.cpp

• Backout link
• Push with failures
• Failure Log

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f9e266070c6
Fix non-unified build errors in netwerk/dns/ r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/241c7cdb3f6b
Fix non-unified build errors in netwerk/cache/ r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/3f8e9b14879d
Fix non-unified build errors in netwerk/cookie/ r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/616f676e8f94
Fix non-unified build errors in netwerk/ipc/ r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/3d31e8c8e194
Fix non-unified build errors in netwerk/protocol/about/ r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/88c33cdcb8aa
Fix non-unified build errors in netwerk/protocol/gio r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/b481b801250e
Fix non-unified build errors in netwerk/protocol/res/ r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/3b2e02c99090
Fix non-unified build errors in netwerk/protocol/websocket/ r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/4af7a3a697ad
Fix non-unified build errors in netwerk/protocol/http/ r=necko-reviewers,kershaw

Comment 15

[Cosmin Sabou [:CosminS]]

Backed out for causing windows hybrid bustages.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=85b747a60e7348d3c650c4188275160839983f86&selectedTaskRun=Gn8hyQMdQcqBkSwQEYWEdw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=354694952&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/c274f0061d801591fa48c44c052f1b52d56b5335

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9d0a8273e84
Fix non-unified build errors in netwerk/dns/ r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/e3889e2e5ba7
Fix non-unified build errors in netwerk/cache/ r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/9f033c2ebd54
Fix non-unified build errors in netwerk/cookie/ r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/f7c18df824c5
Fix non-unified build errors in netwerk/ipc/ r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/20db87ff5cb9
Fix non-unified build errors in netwerk/protocol/about/ r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/2517bd5db4e4
Fix non-unified build errors in netwerk/protocol/gio r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/97722de49827
Fix non-unified build errors in netwerk/protocol/res/ r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/12c18a5eb2bb
Fix non-unified build errors in netwerk/protocol/websocket/ r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/31b0022d199c
Fix non-unified build errors in netwerk/protocol/http/ r=necko-reviewers,kershaw

Comment 17

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b9d0a8273e84
https://hg.mozilla.org/mozilla-central/rev/e3889e2e5ba7
https://hg.mozilla.org/mozilla-central/rev/9f033c2ebd54
https://hg.mozilla.org/mozilla-central/rev/f7c18df824c5
https://hg.mozilla.org/mozilla-central/rev/20db87ff5cb9
https://hg.mozilla.org/mozilla-central/rev/2517bd5db4e4
https://hg.mozilla.org/mozilla-central/rev/97722de49827
https://hg.mozilla.org/mozilla-central/rev/12c18a5eb2bb
https://hg.mozilla.org/mozilla-central/rev/31b0022d199c

Comment 18

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1733356 - Fix non-unified build errors in netwerk/streamconv/converters/ r=#necko

Comment 19

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1733356 - Fix non-unified build errors in netwerk/url-classifier/ r=#necko

Depends on D129498

Comment 20

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1733356 - Fix non-unified build errors in netwerk/socket/ r=#necko

Depends on D129499

Comment 21

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1733356 - Fix non-unified build errors in netwerk/test/gtest/ r=#necko

Depends on D129500

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16a8dfb7bf53
Fix non-unified build errors in netwerk/streamconv/converters/ r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/731f3033642d
Fix non-unified build errors in netwerk/url-classifier/ r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/a798c107e3ff
Fix non-unified build errors in netwerk/socket/ r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/691526e0a994
Fix non-unified build errors in netwerk/test/gtest/ r=necko-reviewers,kershaw

Comment 23

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/16a8dfb7bf53
https://hg.mozilla.org/mozilla-central/rev/731f3033642d
https://hg.mozilla.org/mozilla-central/rev/a798c107e3ff
https://hg.mozilla.org/mozilla-central/rev/691526e0a994

Comment 24

[[:sergesanspaille]]

Attachment: Bug 1733356 - Fix non-unified build errors in netwerk/ r=dragana!

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5876fd60bbe5
Fix non-unified build errors in netwerk/ r=necko-reviewers,valentin

Comment 26

[Norisz Fay [:noriszfay]]

Backed out for causing bustages on Predictor.cpp

Backout link

Push with failures

Failure log

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97bab99ef206
Fix non-unified build errors in netwerk/ r=necko-reviewers,valentin

Comment 28

[Paul Adenot (:padenot)]

Attachment: Bug 1733356 - Fix build, remove unused global variable in nsInputStreamPump.cpp

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dead7940f720
Fix build, remove unused global variable in nsInputStreamPump.cpp r=sergesanspaille,valentin

Comment 30

[Paul Adenot (:padenot)]

Attachment: Bug 1733356 - Fix build, remove unused global variable in nsStandardURL.cpp. r?valentin,sergesanspaille

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5398605eb0af
Fix build, remove unused global variable in nsStandardURL.cpp. r=sergesanspaille

Comment 32

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/97bab99ef206
https://hg.mozilla.org/mozilla-central/rev/dead7940f720
https://hg.mozilla.org/mozilla-central/rev/5398605eb0af

Comment 33

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82401ab6dedb
Backed out 3 changesets for causing several hybrid bustages.

Comment 34

[Cosmin Sabou [:CosminS]]

Backed out 3 changesets (Bug 1733356) for causing several hybrid bustages.
Unfortunately after those two fixes there was also this fail left.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&fromchange=f259e02b50c5815861cbdb6237974936c5cdc36d&searchStr=hybrid&tochange=609890ddffaef7dbc4c5b64c53292aa2257bf5a3&selectedTaskRun=VDKviiVpSryigja-cY8GRg.0

Failure logs: https://treeherder.mozilla.org/logviewer?job_id=406848628&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=406835001&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=406851933&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/82401ab6dedb6e8fb4b34179ef1d81c55f31d3f6

Comment 35

[Serban Stanca [:SerbanS]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/82401ab6dedb6e8fb4b34179ef1d81c55f31d3f6

Comment 36

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71e2a2742aa1
Fix non-unified build errors in netwerk/ r=necko-reviewers,valentin

Comment 37

[[:sergesanspaille]]

I pushed a new version where all hybrid build pass: https://treeherder.mozilla.org/jobs?repo=try&revision=3859bfd5a17df4a0eb2dac3d45e9c2949ccabf47

Comment 38

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/71e2a2742aa1

Comment 39

[Andra Esanu (needinfo me)]

(In reply to Pulsebot from comment #29)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dead7940f720
Fix build, remove unused global variable in nsInputStreamPump.cpp
r=sergesanspaille,valentin

== Change summary for alert #37419 (as of Wed, 01 Mar 2023 10:44:03 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
8%	reddit-billgates-ama.billg-ama SpeedIndex	windows10-64-shippable-qr	cold fission webrender	1,545.75 -> 1,415.83
8%	reddit-billgates-ama.billg-ama SpeedIndex	windows10-64-shippable-qr	cold fission webrender	1,550.71 -> 1,425.42

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=37419