Closed Bug 1733422 Opened 2 months ago Closed 1 month ago

SessionStore.getClosedWindowData should always return an object

Categories

(Firefox :: Session Restore, task)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: standard8, Assigned: onuohaoluebube05, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

SessionStore.getClosedWindowData is only called in production code with the aAsString argument as false.

In test code, the majority of tests call JSON.parse to translate the string back into an object.

We can therefore drop the string option, and have it always return an object. Note this is split out from bug 1505572.

For running tests (after building), you'll want to do ./mach mochitest path/to/test.

I'm happy to mentor this. For instructions on how to get your local build of Firefox up and running and submit your patch, see https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Note this bug will be auto-assigned when the first patch is attached.

Summary: Remove SessionStore.getClosedWindowData should always return an object → SessionStore.getClosedWindowData should always return an object

Hi, I'd like to help with this!! I'm getting my local build up now!
I'm not very strong in js, but I'm up for the challenge.

Sure, no-one else has started yet, as I said in comment 0, this will be auto-assigned when the first patch is attached.

Assignee: nobody → onuohaoluebube05
Status: NEW → ASSIGNED
Attachment #9247061 - Attachment description: Bug 1733422 - SessionStore.getClosedWindowData always returns an object r=Mark Banner (:standard8) → Bug 1733422 - SessionStore.getClosedWindowData always returns an object r=Standard8
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ba9f1947404
SessionStore.getClosedWindowData always returns an object r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.