1733422 - SessionStore.getClosedWindowData should always return an object

Status: RESOLVED FIXED

(Firefox :: Session Restore, task)

Description

[Mark Banner (:standard8)]

SessionStore.getClosedWindowData is only called in production code with the aAsString argument as false.

In test code, the majority of tests call JSON.parse to translate the string back into an object.

We can therefore drop the string option, and have it always return an object. Note this is split out from bug 1505572.

For running tests (after building), you'll want to do ./mach mochitest path/to/test.

I'm happy to mentor this. For instructions on how to get your local build of Firefox up and running and submit your patch, see https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Note this bug will be auto-assigned when the first patch is attached.

Comment 1

[secret.okra-0z]

Hi, I'd like to help with this!! I'm getting my local build up now!
I'm not very strong in js, but I'm up for the challenge.

Comment 2

[Mark Banner (:standard8)]

Sure, no-one else has started yet, as I said in comment 0, this will be auto-assigned when the first patch is attached.

Comment 3

[onuohaoluebube05]

Attachment: Bug 1733422 - SessionStore.getClosedWindowData always returns an object r=Standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ba9f1947404
SessionStore.getClosedWindowData always returns an object r=Standard8

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9ba9f1947404