1733440 - Account for parent accs with no frame in bounds caching impl

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[Morgan Reschenberg [:morgan]]

Jamie's phab comment describing this below :)

If the parent doesn't have a frame but the grandparent (or some other ancestor) does, I think this will break the coordinates, since we're getting root-relative coordinates here. When we calculate bounds in RemoteAccessible::Bounds, we'll add the root-relative coords here, then keep walking up the ancestry adding more coordinates... but we already had root-relative coordinates!

If we're going to use root-relative coordinates, I think we need to push some flag indicating that RemoteAccessible shouldn't add bounds from the ancestry for this Accessible.

Alternatively, we could find the nearest parent Accessible with a frame and use that here.

As to when this actually matters, display: contents will cause an Accessible to have no frame:

data:text/html,<div>before<ul style="display: contents;"><li style="display: contents;">item

The div will have a frame, the ul and the li won't, but the "item" text will have a frame. So, we'll use root-relative coordinates for the "item" TextLeafAccessible, but end up adding the div coordinates as well.

Comment 1

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1733440: Adjust RemoteAccessibleBase::Bounds for root relative coordinates r?Jamie

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ed33cbbaea5
Adjust RemoteAccessibleBase::Bounds for root relative coordinates r=Jamie

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9ed33cbbaea5