1733475 - stickers panel is not fully displayed on app.element.io

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Ksenia Berezina [:ksenia]]

Attachment: 84751.html

This was originally reported in https://github.com/webcompat/web-bugs/issues/84751

To reproduce:

1. Open the attached test case 84751.html in Firefox release/ Nightly and observe the block on the right

Expected:
The panel inside the iframe is fully visible

Actual:
The width of the panel is around 5px, so only a small part of it is visible

The issue only happens when I change the display property of a wrapper element dynamically with a setTimeout and works ok if the element is displayed by default. This is just to illustrate the behaviour - on the original site, it is changed on click.

From mozregression:

 2:43.09 INFO: Narrowed integration regression window from [98a3f624, a74fee26] (3 builds) to [98a3f624, 58909c79] (2 builds) (~1 steps left)
 2:43.09 INFO: No more integration revisions, bisection finished.
 2:43.09 INFO: Last good revision: 98a3f624dd0822d471b46703d4cb0c8bafc1674b
 2:43.09 INFO: First bad revision: 58909c79343bc9145173cfcd54c277cd343eb2a8
 2:43.09 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=98a3f624dd0822d471b46703d4cb0c8bafc1674b&tochange=58909c79343bc9145173cfcd54c277cd343eb2a8

Comment 1

[Ksenia Berezina [:ksenia]]

Attachment: 84751-iframe.html

Comment 2

[Ksenia Berezina [:ksenia]]

Attachment: 84751.html

Comment 3

[Ksenia Berezina [:ksenia]]

Hi Emilio, could you please take a look?

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Thanks for the excellent reduced test-case Ksenia! Of course, will take a look.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1733475 - Ensure to copy over the viewport/font units invalidation bits when reusing reset properties. r=jfkthame,#style

Comment 6

[Ksenia Berezina [:ksenia]]

Thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27a8244cc1ff
Ensure to copy over the viewport/font units invalidation bits when reusing reset properties. r=jfkthame

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31070 for changes under testing/web-platform/tests

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/27a8244cc1ff

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for ESR uplift?

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9243928 [details]
Bug 1733475 - Ensure to copy over the viewport/font units invalidation bits when reusing reset properties. r=jfkthame,#style

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Simple invalidation correctness fix.
• User impact if declined: comment 0
• Fix Landed on Version: 94
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Copy some bits so that we invalidate correctly in some edge cases. Very simple fix.
• String or UUID changes made by this patch: none

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9243928 [details]
Bug 1733475 - Ensure to copy over the viewport/font units invalidation bits when reusing reset properties. r=jfkthame,#style

Approved for 91.3esr.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/6c072c3d7d9e