1733576 - Ctrl-Q/Cmd-q quit warning shows a PluralForm warning (PluralForm.jsm: Index #0 of ';Close #1 tabs?' for value 1 is invalid -- plural rule #1; called by BG__onQuitRequest) in the browser console when invoked with a single window+tab

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[:Gijs (he/him)]

STR:

1. open Firefox on macOS/Linux
2. ensure that only 1 tab in 1 window is open
3. hit the quit shortcut (cmd/ctrl-q)

ER:
no warnings in the console when the dialog shows up

AR:

PluralForm.jsm: Index #0 of ';Close #1 tabs?' for value 1 is invalid -- plural rule #1; called by BG__onQuitRequest

This is because we're trying to access the "singular" value for the PluralForm, which is unexpected.

Comment 1

[Neil Deakin]

Attachment: Bug 1733576, remove extraneous attempt to get the close tabs dialog title, r=gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24c9d3d650b1
remove extraneous attempt to get the close tabs dialog title, r=Gijs

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/24c9d3d650b1

Comment 4

[Marco Castelluccio [:marco]]

Set release status flags based on info from the regressing bug 1726736

Comment 5

[Negritas Sergiu, Desktop QA]

Hello! I have managed to reproduce the issue with firefox 94.0a1 (2021-10-01) on Ubuntu 20.04. I can confirm that the issue is fixed with firefox 94.0b8 and 95.0a1 (2021-10-21) on MacOS and Ubuntu 20.

I will update the flags and set the correct resolution.

Thank you!