1733659 - Clean up naming style in unified intl Locale

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement, P3)

Description

[Dan Minor [:dminor]]

In Bug 1719746 we're moving the LanguageTag implementation into a unified Locale. To minimize unnecessary diferences in the review, the SpiderMonkey style for method, argument and variable names was not changed. We should clean this up after Bug 1719746 lands.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1733659 - Clean up naming style in Locale; r=#platform-i18n-reviewers!

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1733659 - Clean up Locale naming style in make_intl_data.py; r=#platform-i18n-reviewers!

Depends on D131511

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e316768591c0
Clean up naming style in Locale; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/9e23aa79fda9
Clean up Locale naming style in make_intl_data.py; r=platform-i18n-reviewers,gregtatum

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/e30a9a397356bc7f72d5e3a2e20f2af309fd801b

Push with failures

Failure log

Comment 5

[Dan Minor [:dminor]]

Didn't think this needed a try run but I forgot there was windows specific code. Building on windows now: https://treeherder.mozilla.org/jobs?repo=try&author=dminor%40mozilla.com&selectedTaskRun=Es3v_fOzR5eB1ZfmQwhS6A.1

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/450bc518b0c4
Clean up naming style in Locale; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/400cfbbebacd
Clean up Locale naming style in make_intl_data.py; r=platform-i18n-reviewers,gregtatum

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/450bc518b0c4
https://hg.mozilla.org/mozilla-central/rev/400cfbbebacd