Closed
Bug 1733886
Opened 3 years ago
Closed 3 years ago
Don't import `DocumentManager` in extensions tests
Categories
(WebExtensions :: General, task, P3)
WebExtensions
General
Tracking
(firefox95 fixed)
RESOLVED
FIXED
95 Branch
Tracking | Status | |
---|---|---|
firefox95 | --- | fixed |
People
(Reporter: mathew.hodson, Assigned: mathew.hodson)
References
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1733851 +++
DocumentManager
is used in three tests:
- toolkit/components/extensions/test/xpcshell/test_ext_contentscript_context.js
- toolkit/components/extensions/test/xpcshell/test_ext_contentscript_context_isolation.js
- toolkit/components/extensions/test/xpcshell/test_ext_contexts_gc.js
It can be replaced with a calls to ExtensionProcessScript.getExtensionChild(extensionId);
and ExtensionContent.getContext(ext, content);
Assignee | ||
Comment 1•3 years ago
|
||
Depends on D127388
Updated•3 years ago
|
Assignee: nobody → mathew.hodson
Comment 2•3 years ago
|
||
Changing severity to NA because it's a task.
Severity: -- → N/A
Priority: -- → P3
Comment 3•3 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mathew.hodson, could you have a look please?
For more information, please visit auto_nag documentation.
Flags: needinfo?(rob)
Flags: needinfo?(mathew.hodson)
Comment 4•3 years ago
|
||
I've just pushed to land
Flags: needinfo?(rob)
Flags: needinfo?(mathew.hodson)
Updated•3 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/926181ea1e20 Don't import `DocumentManager` in extensions tests. r=robwu
Comment 6•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox95:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•