1733952 - lume.io menu misaligned on desktop.

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

See https://github.com/webcompat/web-bugs/issues/88484#issuecomment-933226651

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1733952 - When computing inline intrinsic sizes, resolve with a 0 percentage basis rather than just resolving to zero if there's a percentage. r=#layout-reviewers

This matches other browsers, the spec
(https://drafts.csswg.org/css-sizing/#cyclic-percentage-contribution):

For the min size properties, as well as for margins and paddings (and
gutters), a cyclic percentage is resolved against zero for determining
intrinsic size contributions.

And also what we do in SizeComputationInput::Compute{Margin,Padding}:

https://searchfox.org/mozilla-central/rev/75e9d727ce5ba2c14653cf8fb0f1367f085271b7/layout/generic/ReflowInput.cpp#2811-2832
https://searchfox.org/mozilla-central/rev/75e9d727ce5ba2c14653cf8fb0f1367f085271b7/layout/generic/ReflowInput.cpp#2861-2868

This fixes a compat issue with the menu alignment in lume.io:

https://github.com/webcompat/web-bugs/issues/88484#issuecomment-933226651

It's also simpler.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fd26f24025c
When computing inline intrinsic sizes, resolve with a 0 percentage basis rather than just resolving to zero if there's a percentage. r=jfkthame

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31098 for changes under testing/web-platform/tests

Comment 4

[Daniel Holbert [:dholbert]]

Thanks for getting to the bottom of this!

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1fd26f24025c

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[trusktr]

Thank you for fixing this. 🙏