Closed Bug 1733955 Opened 2 months ago Closed 1 month ago

Disable window occlusion on some tests

Categories

(Core :: Widget: Win32, task)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Window occlusion caused test timeout failures on several test. It seems necessary to disable window occlusion on these tests.
https://treeherder.mozilla.org/jobs?repo=try&revision=16c4bc573147b78f232926b3cd0476986c51770e

Blocks: 1688997
Assignee: nobody → sotaro.ikeda.g
Depends on: 1734505
Blocks: 1732736
Attachment #9244205 - Attachment description: Bug 1733955 - Disable window occlusion on mochitest and web platform test → WIP: Bug 1733955 - Disable window occlusion on mochitest and web platform test

From gfx-apac meeting

  • It is OK to disable Window Occlusion on web platform test
  • We need to run common test suites with window occlusion.

Test results without disabling window occlusion, there are many timeout failures.
https://treeherder.mozilla.org/jobs?repo=try&revision=7a63a269ffe34c6aad407cab4a517b8ed27325e1

Attachment #9244205 - Attachment description: WIP: Bug 1733955 - Disable window occlusion on mochitest and web platform test → WIP: Bug 1733955 - Disable window occlusion on all web platform tests and mochitest's some tests.

Looking into why testing window was occluded by other window during test.
There were 3 causes to cause window occlusion

  • [1] Multiple Firefox instances existed. A window of one instance occluded other window of another instance.
    • This happened frequently during web platform tests.
  • [2] One test created multiple windows. One window occluded other window.
    • On CI, display size seemed small, it caused testing windows were often maximized.
    • Multiple maximized windows caused window occlusion.
  • [3] window is not shown(does not have WS_VISIBLE). The window is judged as occluded.

Looked into why tests timeout failures by window occlusion did not happen on macOS.

  • On macOS, "occlusionstatechange" event happened less often. It seems to related to the failures difference.
  • On macOS, window's sizes were not maximized during tests. On Windows, Majority of windows were maximized.

Maximized windows caused "occlusionstatechange" events on Windows.
It might be related to window size difference. macOS had bigger display size.

  • macOS display size: 1920 * 1080
  • Windows display size: 1280 * 1024

When non-maximized Firefox windows had same size and position, it caused "occlusionstatechange" event on Window.
But it did not cause "occlusionstatechange" event on macOS.
On macOS, window corners are rounded. I wonder if it might be related to it.

Looked into why testing windows were maximized on Windows.

CI testing PC's display size was (1280 * 1024). With the size, following code was hit. It caused the maximized window.

Depends on: 1737526
Attachment #9244205 - Attachment description: WIP: Bug 1733955 - Disable window occlusion on all web platform tests and mochitest's some tests. → Bug 1733955 - Disable window occlusion on all web platform tests and mochitest's some tests
Pushed by sikeda.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae7da4eda98f
Disable window occlusion on all web platform tests and mochitest's some tests r=jrmuizel,gfx-reviewers
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31411 for changes under testing/web-platform/tests
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Upstream PR merged by jgraham
You need to log in before you can comment on or make changes to this bug.