Open Bug 1733994 Opened 3 years ago Updated 2 years ago

Retry network requests in `UpdateService.jsm` without proxy

Categories

(Toolkit :: Application Update, enhancement, P3)

Product:
Toolkit
Component:
Application Update
Type:
enhancement

Tracking

()

People

(Reporter: nalexander, Unassigned)

References

Details

(Whiteboard: [fidedi-ope])

A bypassProxy flag has been added to certain network requests in https://phabricator.services.mozilla.com/D126550. Sibling to Bug 1732792 (for remote settings), it would be good if UpdateService.jsm retried requests if there is a failure, and the request was using a proxy.

The relevant error handling for network issues is around https://searchfox.org/mozilla-central/rev/75e9d727ce5ba2c14653cf8fb0f1367f085271b7/toolkit/mozapps/update/UpdateService.jsm#5876. It's complex (read: battle-hardened) but it should be possible to eventually try after bypassing any proxies.

Component: Remote Settings Client → Application Update
Product: Firefox → Toolkit

Using ServiceRequest.jsm in UpdateService.jsm might be a prerequisite for this work.

Whiteboard: [fidedi-ope]

If we do this, please be sure it can be disabled in some manner (perhaps only enabled if --enable-proxy-bypass-protection is not present?) for Tor.

You need to log in before you can comment on or make changes to this bug.