1734132 - Translate necko priorities to http3 priorities and pass them to neqo

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P1)

Description

[Manuel Bucher [:manuel]]

It can be similar handled like in http2:

• In http2: https://searchfox.org/mozilla-central/source/netwerk/protocol/http/Http2Session.cpp#449,571-572
• In http3: https://searchfox.org/mozilla-central/source/netwerk/protocol/http/Http3Session.cpp#741,775

The priority_update is handled in http2 in https://searchfox.org/mozilla-central/rev/9bc5dcea99c59dc18eae0de7064131aa20cfbb66/netwerk/protocol/http/Http2Stream.cpp#1272

The interesting priorities to map are: https://searchfox.org/mozilla-central/source/__GENERATED__/dist/include/nsIClassOfService.h#46-50,52
In http3 priorities 3-7 are available

Comment 1

[Manuel Bucher [:manuel]]

Attachment: Bug 1734132 - Map necko priorities to http3 priorities r=#necko

Comment 2

[Manuel Bucher [:manuel]]

Attachment: Bug 1734132 - Add neqo glue code to send priority updates r=#necko

Comment 3

[Manuel Bucher [:manuel]]

Attachment: Bug 1734132 - Test that different http3 priorities are sent r=#necko

Depends on D127834

Comment 4

[Manuel Bucher [:manuel]]

Attachment: Bug 1734132 - Fix style in xpcshell.ini to satisfy `mach lint --warnings --outgoing` r=#necko

Depends on D127834

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/513d740d6477
Add neqo glue code to send priority updates r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/9516eb1214d8
Map necko priorities to http3 priorities r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/511af4b42efc
Test that different http3 priorities are sent r=necko-reviewers,dragana

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26b9d11d5442
Backed out 3 changesets for causing bustages in Http3Stream.cpp

Comment 7

[Alexandru Michis [:malexandru]]

Backed out 3 changesets (Bug 1734132) for causing bustages in Http3Stream.cpp
Backout link: https://hg.mozilla.org/integration/autoland/rev/26b9d11d544282e9df26f4ef8852ac918e63c348
Push with failures, failure log.

Comment 8

[Manuel Bucher [:manuel]]

Sorry, an include was missing. I thought, that I ran treeherder beforehand, but now I am sure that it is passing: https://treeherder.mozilla.org/jobs?repo=try&revision=8c95d5ee15cc295852278010e4aa83924129bbe8

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51ba73eb5bc2
Add neqo glue code to send priority updates r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/aee682c3af71
Map necko priorities to http3 priorities r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/51a131c3817b
Test that different http3 priorities are sent r=necko-reviewers,dragana

Comment 10

[Natalia Csoregi [:nataliaCs]]

Backed out for bustage on Http3Stream.cpp

• backout: https://hg.mozilla.org/integration/autoland/rev/6942734d88f0d26528b0fb821b2d7a425e698ff5

• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=51a131c3817b277c4630980340897863b9395912

• push where it first appeared: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=8ce662d1dd0e80922eaa4d675c095a22d3cebf31

• failure log: https://treeherder.mozilla.org/logviewer?job_id=358340138&repo=autoland&lineNumber=49876

[task 2021-11-17T16:46:23.877Z] 16:46:23     INFO -  /builds/worker/checkouts/gecko/netwerk/protocol/http/Http3Stream.cpp(171,21): error: no member named 'network_http_http3_send_background_tabs_depriorization' in namespace 'mozilla::StaticPrefs'
[task 2021-11-17T16:46:23.877Z] 16:46:23     INFO -    if (!StaticPrefs::network_http_http3_send_background_tabs_depriorization() ||
[task 2021-11-17T16:46:23.877Z] 16:46:23     INFO -         ~~~~~~~~~~~~~^
[task 2021-11-17T16:46:23.877Z] 16:46:23     INFO -  /builds/worker/checkouts/gecko/netwerk/protocol/http/Http3Stream.cpp(532,21): error: no member named 'network_http_http3_priorization' in namespace 'mozilla::StaticPrefs'
[task 2021-11-17T16:46:23.877Z] 16:46:23     INFO -    if (!StaticPrefs::network_http_http3_priorization()) {
[task 2021-11-17T16:46:23.878Z] 16:46:23     INFO -         ~~~~~~~~~~~~~^
[task 2021-11-17T16:46:23.878Z] 16:46:23     INFO -  /builds/worker/checkouts/gecko/netwerk/protocol/http/Http3Stream.cpp(537,20): error: no member named 'network_http_http3_send_background_tabs_depriorization' in namespace 'mozilla::StaticPrefs'
[task 2021-11-17T16:46:23.878Z] 16:46:23     INFO -    if (StaticPrefs::network_http_http3_send_background_tabs_depriorization() &&
[task 2021-11-17T16:46:23.878Z] 16:46:23     INFO -        ~~~~~~~~~~~~~^
[task 2021-11-17T16:46:23.878Z] 16:46:23     INFO -  /builds/worker/checkouts/gecko/netwerk/protocol/http/Http3Stream.cpp(546,21): error: no member named 'network_http_http3_priorization' in namespace 'mozilla::StaticPrefs'
[task 2021-11-17T16:46:23.878Z] 16:46:23     INFO -    if (!StaticPrefs::network_http_http3_priorization()) {
[task 2021-11-17T16:46:23.878Z] 16:46:23     INFO -         ~~~~~~~~~~~~~^
[task 2021-11-17T16:46:23.878Z] 16:46:23     INFO -  4 errors generated.
[task 2021-11-17T16:46:23.878Z] 16:46:23    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:661: Http3Stream.obj] Error 1
[task 2021-11-17T16:46:23.878Z] 16:46:23     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/netwerk/protocol/http'
[task 2021-11-17T16:46:23.878Z] 16:46:23     INFO -  gmake[4]: *** Waiting for unfinished jobs....

Comment 11

[Natalia Csoregi [:nataliaCs]]

Also failing:

• TEST-UNEXPECTED-TIMEOUT | netwerk/test/unit/test_http3_prio.js | Test timed out

Comment 12

[Manuel Bucher [:manuel]]

Headers now properly included: https://treeherder.mozilla.org/jobs?repo=try&revision=f107b6b561c0a12054f042818a4849e2a0cfb74d
Opened https://github.com/mozilla/neqo/issues/1271 for test failure.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cc045cb1170
Add neqo glue code to send priority updates r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/3557e56433c7
Map necko priorities to http3 priorities r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/c2f845b6643c
Test that different http3 priorities are sent r=necko-reviewers,dragana

Comment 14

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0cc045cb1170
https://hg.mozilla.org/mozilla-central/rev/3557e56433c7
https://hg.mozilla.org/mozilla-central/rev/c2f845b6643c