1734210 - Setting default headers (mail.identity.default.headers) is incorrect if their value contains a colon

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Alfred Peters [:infofrommozilla]]

Tested with TB91.1.2 and Trunk

STR:

• Set the prefs (without quotation marks):
  mail.identity.default.headers: "XHeader1"
  mail.identity.default.header.XHeader1: "X-Foo: abc def: ghi"
• Create a new email or news article
• Send it or save it as draft
  => check the header: It's truncated at the colon

Set: mailnews.send.jsmodule to false an restart TB and the header will be fine.

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1734210 - Fix sending default custom header value with colons. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0eb27981969b
Fix sending default custom header value with colons. r=mkmelin

Comment 3

[Alfred Peters [:infofrommozilla]]

Thanks, works fine with the current daily.

Is it worth uplifting?
The bug is not so dramatic. On the other hand, the uplift should also be possible without danger.

Comment 4

[Ping Chen [:rnons] (away)]

Comment on attachment 9244449 [details]
Bug 1734210 - Fix sending default custom header value with colons. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1211292
User impact if declined: If custom default header value contains colon, it will be clipped when sent
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9244449 [details]
Bug 1734210 - Fix sending default custom header value with colons. r=mkmelin

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 94.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/a1113053d42e

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9244449 [details]
Bug 1734210 - Fix sending default custom header value with colons. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 91.3.0:
https://hg.mozilla.org/releases/comm-esr91/rev/002d2d648a66

Comment 9

[Alfred Peters [:infofrommozilla]]

(In reply to Rob Lemley [:rjl] from comment #8)

Thunderbird 91.3.0:

Verified for TB91.3