1734243 - Implement ReadableStream.pipeThrough

Status: RESOLVED FIXED

(Core :: DOM: Streams, task, P3)

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Seems pipeThrough is a short wrapper on top of pipeTo, without direct dependency for TransformStream.

Comment 2

[Tom S [:evilpie]]

TransformStream is not a direct dependency, but it's meant to be used together. I think the only difficult thing for implementing pipeThrough is

Step 5. Set promise.[[PromiseIsHandled]] to true.

We have Promise::SetSettledPromiseIsHandled, but I think in this case the promise actually isn't settled.

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

This sounds like a lower hanging fruit than the whole TransformStream...

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1734243 - Part 1: Add JS::SetAnyPromiseIsHandled r=arai

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1734243 - Part 2: Implement ReadableStream#pipeThrough r=mgaudet,evilpie

Depends on D139505

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1734243 - Part 3: Use SetAnyPromiseIsHandled in ServiceWorkerScriptCache r=smaug

Depends on D139506

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d89c07e28e42
Part 1: Add JS::SetAnyPromiseIsHandled r=arai

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d89c07e28e42

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5a25a5870f1
Part 2: Implement ReadableStream#pipeThrough r=mgaudet,evilpie,emilio
https://hg.mozilla.org/integration/autoland/rev/b4538bb5c349
Part 3: Use SetAnyPromiseIsHandled in ServiceWorkerScriptCache r=smaug

Comment 10

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1734243 - Part 4: Add missing AbortSignal header in PipeTo

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/886bd2c17225
Part 4: Add missing AbortSignal header in PipeTo. CLOSED TREE

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/c5a25a5870f1
https://hg.mozilla.org/mozilla-central/rev/b4538bb5c349
https://hg.mozilla.org/mozilla-central/rev/886bd2c17225