1734346 - The text in the menupopup of menubar/Bookmarks Toolbar is displayed as grayscale AA instead of subpixel AA.

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Alice0775 White]

Steps to reproduce:

1. Open menupopup from menubar (Alt > B)
   Or
   Open folder in Bookmarks toolbar

Actual Results:
The text in the menupopup is displayed as grayscale AA instead of subpixel AA.

Expected Results:
Should be subpixel AA.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d0180eae3832b10e90f9815b0f4f79b071b25dbe&tochange=8ff0f5b38b62daeb35dfb551e5f3b45262298e09

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression, causing blurry, fuzzy and unsharp fonts.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1724617

Comment 3

[Glenn Watson [:gw]]

I confirmed that this is because the opaque background rect that is found by WR for those popups has a rounded-rect clip. WR currently conservatively assumes that those aren't suitable for subpixel backgrounds. I'll add support for this case, it shouldn't be much work.

Comment 4

[Matt Woodrow (:mattwoodrow)]

Display list: https://paste.mozilla.org/gTO10RCJ

Comment 5

[Glenn Watson [:gw]]

Attachment: Bug 1734346 - Support backdrops with simple rounded-rect clip cases.

This allows picture slice backdrops to be supported when they contain
rounded-rect clip(s) that are in the same coordinate system as the
primitive. This is the common case, and allows subpixel AA to be
used in bookmark menu and other popups that are part of the current
Gecko UI.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84cd7d23ca18
Support backdrops with simple rounded-rect clip cases. r=gfx-reviewers,nical

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/84cd7d23ca18

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9245392 [details]
Bug 1734346 - Support backdrops with simple rounded-rect clip cases.

Beta/Release Uplift Approval Request

• User impact if declined: This is needed to subpixel-AA with bug 1724617
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively low risk and should be covered reasonably well by tests.
• String changes made/needed:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9245392 [details]
Bug 1734346 - Support backdrops with simple rounded-rect clip cases.

Approved for 94.0b7.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/81514f8cc0b8

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Bug 1724617 exposed this issue in a new way, but it's older than that as evidenced by the other bugs this patch fixed.

Comment 12

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 95.0a1 (2021-10-14), so I'm marking this bug as VERIFIED.
Thank you very much! \o/

Comment 13

[Ryan VanderMeulen [:RyanVM]]

This grafts cleanly to ESR91 and seems like a good quality of life improvement for affected users with no known regressions. Did you want to nominate this for uplift, Glenn?

Comment 14

[Glenn Watson [:gw]]

Comment on attachment 9245392 [details]
Bug 1734346 - Support backdrops with simple rounded-rect clip cases.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Significant rendering quality improvement in some cases.
• User impact if declined: Missing subpixel AA in more cases than otherwise, including some parts of the FF UI.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively small patch, has been in nightly for some time now.
• String or UUID changes made by this patch:

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9245392 [details]
Bug 1734346 - Support backdrops with simple rounded-rect clip cases.

Nice QoL improvement for affected users. Approved for 91.4esr.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/dbc484a1edb9

Comment 17

[Simona Badau, Desktop QA]

Tried to verify this on Firefox 91.4.0 esr, but I'm surely missing some steps because I can't seem to reproduce the initial issue.
Virtual_ManPL, when time permits, could you please install the latest Firefox 91.4.0 esr and confirm this issue is fixed here also? You can download the build from here.

Comment 18

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that the bug is fixed also in Mozilla Firefox ESR 91.4.1 (ID: 20211215182543) [rev:a1fd35b0b8f66b8660de9ed95223120765de2e11], so I'm marking this bug as VERIFIED.
Thank you very much! \o/

Comment 19

[Simona Badau, Desktop QA]

Thanks, Virtual_ManP for all the help!
Based on Comment 18, removing the qe-verify+ flag.