1734421 - Crash in [@ abort | wasm_rt_allocate_memory]

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Windows crash, mostly 32-bit but only the 64-bit crashes have usable stacks.

Stack is very similar to bug 1733686.

Crash report: https://crash-stats.mozilla.org/report/index/33dc9b81-9bc7-47b5-b534-7ead30211006

Reason: STATUS_FATAL_APP_EXIT

Top 10 frames of crashing thread:

0 ucrtbase.dll abort 
1 rlbox.dll wasm_rt_allocate_memory third_party/wasm2c/wasm2c/wasm-rt-impl.c:137
2 rlbox.dll create_wasm2c_sandbox /builds/worker/workspace/obj-build/security/rlbox/rlbox.dll.wasm.c:613317
3 xul.dll rlbox::rlbox_wasm2c_sandbox::impl_create_sandbox third_party/rlbox_wasm2c_sandbox/include/rlbox_wasm2c_sandbox.hpp:451
4 xul.dll rlbox::rlbox_sandbox<rlbox::rlbox_wasm2c_sandbox>::create_sandbox<char16ptr_t> third_party/rlbox/include/rlbox_sandbox.hpp:383
5 xul.dll RLBoxHunspell::RLBoxHunspell extensions/spellcheck/hunspell/glue/RLBoxHunspell.cpp:41
6 xul.dll mozHunspell::SetDictionary extensions/spellcheck/hunspell/glue/mozHunspell.cpp:189
7 xul.dll mozSpellChecker::SetCurrentDictionary extensions/spellcheck/src/mozSpellChecker.cpp:447
8 xul.dll mozilla::RemoteSpellcheckEngineParent::RecvSetDictionaryFromList extensions/spellcheck/hunspell/glue/RemoteSpellCheckEngineParent.cpp:29
9 xul.dll mozilla::PRemoteSpellcheckEngineParent::OnMessageReceived ipc/ipdl/PRemoteSpellcheckEngineParent.cpp:290

Comment 1

[Shravan Narayan]

investigating

Comment 2

[Shravan Narayan]

Looks like this bug (1734421) is an error when there is no space to create an rlbox sandbox, while the other bug mentioned (bug 1733686) is to do with the sandbox internally running out of memory.

@glandium In the case of the most frequent x86 32bit platform crashes, I think the fix is a modified version of "part 1 of Bug 1728934" (which got backed out in its current form). I need to update this patch, but this will ensure that we make better use of the limited available virtual memory in 32-bit applications. I will need to look more into the one or two x64/arm64 related crashes here.

Comment 3

[Shravan Narayan]

Attachment: Bug 1734421 - Update wasm2c to support better use of 32-bit virtual space r=glandium

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Bug 1727266 was backed out for 94.0b3, so hopefully we'll see these crashes go away there.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)

Bug 1727266 was backed out for 94.0b3, so hopefully we'll see these crashes go away there.

No crashes in 94.0b3.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e1011402c79
Update wasm2c to support better use of 32-bit virtual space r=glandium

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6e1011402c79