1734504 - After updating to 94.0b1, calendar "start the week on" setting changes from Sunday to Saturday

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Arthur K. (he/him)]

STR:

1. Have 93.0b installed and note your "start the week on" setting in Tools > Preferences > Calendar. I've had mine set to Sunday for the better part of a decade
2. Update to the test build of 94.0b1

You'll notice the mini-month view shows Saturday as the starting day for the week and the Tools > Preferences > Calendar setting has now changed to Saturday. I noticed this on my work PC this morning. I thought it was a fluke. I came home and checked my home PC and it's set to Saturday as well.

I was able to fix by setting it back to Sunday.

Comment 1

[Magnus Melin [:mkmelin]]

I notice this as well, but had not had the time to track it down.
Seems like an off-by-one error. Mine was set to start on Monday, and jumped to Sunday. Tried an old profile not started with this version, and it also got Sunday for default.

Comment 2

[Martin Schröder [:mschroeder]]

From my pov, it is more likely to be a regression from bug 1732420 as it fiddled with calendarInfo and the weekend... or we are missing a part while porting changes needed from bug 1728180. This bug has changes related to first day of week in https://phabricator.services.mozilla.com/D126228.

Comment 3

[Martin Schröder [:mschroeder]]

It seems days encoding changed from 1=Sunday to 7=Saturday to 1=Monday to 7=Sunday. So, https://hg.mozilla.org/comm-central/rev/9671b0bbcd26#l1.6 needs to be adapted to still give the same result as before.

Comment 4

[Magnus Melin [:mkmelin]]

Thanks!

Comment 5

[Martin Schröder [:mschroeder]]

Attachment: Bug 1734504 - Correctly calculate the "start the week on" setting if still using default. r=darktrojan

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7696e6d0ef29
Correctly calculate the "start the week on" setting if still using default. r=darktrojan

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9244838 [details]
Bug 1734504 - Correctly calculate the "start the week on" setting if still using default. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #): bug 1732420
User impact if declined: calendars start on a different day of the week, could be really annoying for some people
Testing completed (on c-c, etc.): just landed
Risk to taking this patch (and alternatives if risky): not risky

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9244838 [details]
Bug 1734504 - Correctly calculate the "start the week on" setting if still using default. r=darktrojan

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 94.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/738a70c4bd24

Comment 10

[WaltS48 [:walts48]]

Verified using 94.0b3 on Windows 10.