1734552 - Don't call View.onProvideAutofillVirtualStructure in GeckoView.onProvideAutofillVirtualStructure

Status: RESOLVED FIXED

(GeckoView :: General, defect, P2)

Description

[Makoto Kato [:m_kato]]

Profile data: https://share.firefox.dev/3DhzY2i

When Autofill services runs on compatibility mode (example, Bitwarden), View.onProvideAutofillStructure (https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/android/view/View.java;l=8779) will walk though the accessibility nodes. Walking though seems to be slow according to profiling data.

Actually, we set autofill data via Autofill.Session.fillViewStructure, so it is unnecessary to walk though all accessibility nodes.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1734552 - Don't walk though the accessibility nodes on autofill. r=#geckoview-reviewers

When Autofill service runs with compatibility mode [*1] (such as Bitwarden),
View.onProvideAutofillStructure walks through the accessibility nodes.
Walking through it spends a lot of times.

When checking Android's source code, the following walks through it.

• onProvideAutofillVirtualStructure
• autofill
• isVisibleToUserForAutofill

Actually, since we already add autofill's virtual nodes, it is unnecessary to
walk through it.

*1 https://developer.android.com/reference/android/service/autofill/AutofillService#compatibility-mode

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d8a5cfeca82
Don't walk though the accessibility nodes on autofill. r=geckoview-reviewers,agi

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/4d8a5cfeca82