Closed Bug 1734570 Opened 1 year ago Closed 1 year ago

New wpt failures in /css/css-cascade/ [layer-basic.html, layer-import.html, layer-keyframes-override.html]

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Assigned: emilio)

References

Details

(Whiteboard: [wpt])

Attachments

(2 files, 1 obsolete file)

Syncing wpt PR 31144 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

/css/css-cascade/layer-basic.html
A2 Anonymous layers: FAIL
A3 Anonymous layers: FAIL
B2 Named layers: FAIL
/css/css-cascade/layer-import.html
A1 Layer rules with import: FAIL
A2 Layer rules with import: FAIL
A3 Layer rules with import: FAIL
B1 Anonymous imports: FAIL
C1 Named imports: FAIL
/css/css-cascade/layer-keyframes-override.html
@keyframes unlayered overrides layered: FAIL

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1734545 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

This shouldn't change behavior jut yet.

Assignee: nobody → emilio
Status: NEW → ASSIGNED

This shouldn't change behavior jut yet.

The bitfield approach worked when the layer order was in pre-order, but
the spec was changed to make it work like post-order and I don't think
there's a way to keep it working like that, so keep the layer order in a
separate data structure that we look up when going from Rule to
ApplicableDeclarationBlock.

This is just a vector index operation so hopefully shouldn't be too bad.

This patch intentionally regresses @keyframe handling to some extent,
since we need a bit more complicated approach and it seemed worth
implementing in a separate patch.

Depends on D129380

Attachment #9247507 - Attachment is obsolete: true
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e91dde66912
Store a LayerOrder in ApplicableDeclarationBlock. r=boris
https://hg.mozilla.org/integration/autoland/rev/8e3a9cbf1e63
Update layer ordering to follow the spec. r=boris
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.