1734570 - New wpt failures in /css/css-cascade/ [layer-basic.html, layer-import.html, layer-keyframes-override.html]

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 31144 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

/css/css-cascade/layer-basic.html
A2 Anonymous layers: FAIL
A3 Anonymous layers: FAIL
B2 Named layers: FAIL
/css/css-cascade/layer-import.html
A1 Layer rules with import: FAIL
A2 Layer rules with import: FAIL
A3 Layer rules with import: FAIL
B1 Anonymous imports: FAIL
C1 Named imports: FAIL
/css/css-cascade/layer-keyframes-override.html
@keyframes unlayered overrides layered: FAIL

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1734545 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1734570 - Store a LayerOrder in ApplicableDeclarationBlock. r=#style

This shouldn't change behavior jut yet.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1734570 - Store a LayerOrder in ApplicableDeclarationBlock. r=#style

This shouldn't change behavior jut yet.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1734570 - Update layer ordering to follow the spec. r=#style

The bitfield approach worked when the layer order was in pre-order, but
the spec was changed to make it work like post-order and I don't think
there's a way to keep it working like that, so keep the layer order in a
separate data structure that we look up when going from Rule to
ApplicableDeclarationBlock.

This is just a vector index operation so hopefully shouldn't be too bad.

This patch intentionally regresses @keyframe handling to some extent,
since we need a bit more complicated approach and it seemed worth
implementing in a separate patch.

Depends on D129380

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e91dde66912
Store a LayerOrder in ApplicableDeclarationBlock. r=boris
https://hg.mozilla.org/integration/autoland/rev/8e3a9cbf1e63
Update layer ordering to follow the spec. r=boris

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/8e91dde66912
https://hg.mozilla.org/mozilla-central/rev/8e3a9cbf1e63