Closed Bug 1734579 Opened 4 years ago Closed 4 years ago

Make block size of doh padding configurable and choose a more sane default

Categories

(Core :: Networking: DNS, enhancement, P2)

Product:
Core
Component:
Networking: DNS
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: manuel, Assigned: manuel)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Bug 1734579 - Make block size of encrypted edns padding configurable r=#necko
48 bytes, text/x-phabricator-request
Details | Review

The request should be padable to powers of two. Currently it is padded to 16 bytes. More would be probably better. I would go to 128 next, but other opinions are welcome.

The config option could look like network.dns.padding.length-pow2 with the default value of 7 = 128 bytes. Maybe instead of adding an option, using a saner default would be sufficient?

Follow up on https://bugzilla.mozilla.org/show_bug.cgi?id=1734165

Assignee: nobody → mbucher
Status: NEW → ASSIGNED
Depends on: 1734165
Flags: needinfo?(valentin.gosu)
Depends on: 1543811
No longer depends on: 1734165
Blocks: doh
Severity: -- → S3
Flags: needinfo?(valentin.gosu)
Priority: -- → P2
Whiteboard: [necko-triaged]

Additionally changing the paddding block size to a saner default

Pushed by mbucher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ba4d3953e07c Make block size of encrypted edns padding configurable r=necko-reviewers,valentin

https://hg.mozilla.org/mozilla-central/rev/ba4d3953e07c

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: