1734722 - CI for DOM Streams

Status: RESOLVED FIXED

(Core :: DOM: Streams, enhancement, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

As we start progressive landing of DOM Streams and DOM Streams features, it would be nice to get some CI started: MVP would be a linux build with

--enable-dom-streams that runs the ReadableStreams WPT tests.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Mitch- can you advise on what is needed for adding a new build with flags? I am happy to help with the tests. If there is a process for builds or certain files to ensure get updated it would be good to know.

Comment 3

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2025-08-18)]

runs the ReadableStreams WPT tests.

Probably should run mochitests too, in case it has any coverage that WPT doesn't cover. (For Fetch and BodyStream)

Comment 4

[Mitchell Hentges [:mhentges] 🦀]

I haven't done this before, so I'm going to redirect to :glandium.
If he doesn't have time, I can dig into this, but I think that'd be a less efficient allocation of resources.

To chuck out a quick guess: we need a new mozconfig for CI that contains the lines:

. "$topsrcdir/browser/config/mozconfigs/linux64/common-opt"
ac_add_options --enable-dom-streams
. "$topsrcdir/build/mozconfig.common.override"

Then, specify the mozconfig-variant, similar to how it's been done over here.

:glandium, am I missing anything?

Comment 5

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2025-08-18)]

Attachment: Bug 1734722 - Part 1: Add CI jobs for DOM Streams r=glandium

Comment 6

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2025-08-18)]

Like this? 👀 This works on mach try chooser, checking if it actually works on the server... https://treeherder.mozilla.org/#/jobs?repo=try&revision=9cc4b7aa02aee931076ee783a99acc8479882d0c

Edit: It does, thanks!
Edit2: With WritableStream disabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1070ce37c44d291b0eeb81803d8350f848bd0959

Comment 7

[Mike Hommey [:glandium]]

Maybe only create a debug build?

Comment 8

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2025-08-18)]

Attachment: Bug 1734722 - Part 2: Add `if not domstreams` to WPT meta r=jgraham!,mgaudet!

Depends on D136812

Comment 9

[Matthew Gaudet (he/him) [:mgaudet]]

I love this. I wish I had known earlier we could make WPT expectations optional like this.

This is going to be super helpful in the last bits. Hopefully we can get this up soon.

Comment 10

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2025-08-18)]

The mochitest failure from dom/tests/mochitest/fetch/test_readableStreams.html also is mMightHaveUnreportedJSException assertion failure.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e684ad3cd11a
Part 1: Add CI jobs for DOM Streams r=glandium
https://hg.mozilla.org/integration/autoland/rev/0a448a73bc66
Part 2: Add `if not domstreams` to WPT meta r=jgraham,mgaudet

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad8a0a511911
Part 1: Add CI jobs for DOM Streams r=glandium
https://hg.mozilla.org/integration/autoland/rev/86e044e96198
Part 2: Add `if not domstreams` to WPT meta r=jgraham,mgaudet

Comment 14

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2025-08-18)]

Attachment: Bug 1734722 - Part 3: Allow domstreams: True in build r=glandium

Comment 15

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2025-08-18)]

Attachment: Bug 1734722 - Part 4: Add domstreams field to fissionregressions.py r=jgraham

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b05d209eddd9
Part 3: Allow domstreams: True in build r=aki
https://hg.mozilla.org/integration/autoland/rev/9a595331d46b
Part 4: Add domstreams field to fissionregressions.py r=jgraham

Comment 17

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ad8a0a511911
https://hg.mozilla.org/mozilla-central/rev/86e044e96198
https://hg.mozilla.org/mozilla-central/rev/b05d209eddd9
https://hg.mozilla.org/mozilla-central/rev/9a595331d46b

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32718 for changes under testing/web-platform/tests

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot