Closed
Bug 1734723
Opened 4 years ago
Closed 4 years ago
Checkbox border disappears when showing focus rings.
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
95 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox-esr91 | --- | unaffected |
| firefox93 | --- | unaffected |
| firefox94 | --- | fixed |
| firefox95 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
diannaS
:
approval-mozilla-beta+
|
Details | Review |
No description provided.
| Assignee | ||
Comment 1•4 years ago
|
||
As those don't draw the outline on top.
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7e2386b59ca2
Don't use transparent borders for checkbox/radio when focused. r=mstange
Updated•4 years ago
|
Keywords: regression
Comment 3•4 years ago
|
||
Set release status flags based on info from the regressing bug 1734115
status-firefox93:
--- → unaffected
status-firefox94:
--- → unaffected
status-firefox95:
--- → affected
status-firefox-esr78:
--- → unaffected
status-firefox-esr91:
--- → unaffected
Comment 4•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
| Assignee | ||
Comment 5•4 years ago
|
||
Comment on attachment 9244870 [details]
Bug 1734723 - Don't use transparent borders for checkbox/radio when focused. r=mstange,dholbert
Beta/Release Uplift Approval Request
- User impact if declined: Regression from bug 1734115 which we want on beta.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Very simple tweak to the non-native theme checkbox painting.
- String changes made/needed: none
Attachment #9244870 -
Flags: approval-mozilla-beta?
Comment 6•4 years ago
|
||
Comment on attachment 9244870 [details]
Bug 1734723 - Don't use transparent borders for checkbox/radio when focused. r=mstange,dholbert
Approved for 94.0b6
Attachment #9244870 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•4 years ago
|
||
| bugherder uplift | ||
Updated•4 years ago
|
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•