1734819 - [wayland] Select popup in web-extension popup doesn't show up.

Status: RESOLVED FIXED

(Core :: Widget, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

This happens regardless of my fix for bug 1732829. If I install this add-on, showing the popup sometimes works, sometimes doesn't. Usually requires 3 or 4 clicks.

(I'm on Gnome 40 on Fedora 34)

Comment 1

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Emilio, is that recent regression?

Comment 2

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Also can you attach log of MOZ_LOG="WidgetPopup:5" when it fails to open?

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

btw. works for me, at least with stock Firefox from Fedora 34 (93.0).

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I'll try to get a regression range.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

It doesn't work for me on stock Fedora 34 either (nor on Nightly, nor on mozregression --launch 93):

Name 	Firefox
Version 	93.0
Build ID 	20211007233316
Distribution ID 	fedora
User Agent 	Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:93.0) Gecko/20100101 Firefox/93.0
OS 	Linux 5.14.10-200.fc34.x86_64 #1 SMP Thu Oct 7 20:49:53 UTC 2021
OS Theme 	Matcha-dark-azul / Matcha-azul
Application Binary 	/usr/lib64/firefox/firefox

Will try to get the log.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: debugging patch

I applied that to make some more sense of the logs. Let me know if you want a version of it landed somehow.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: bad.log

This is a log of just opening the extension popup and clicking on the select (which didn't show up).

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: better.log

This is a log of me doing the same but clicking on the select a couple times, which eventually opened it.

Comment 9

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)

I applied that to make some more sense of the logs. Let me know if you want a version of it landed somehow.

Yes please, it looks great!

Comment 10

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Can you please run with MOZ_LOG="Widget:5, WidgetPopup:5", click only once on the extension button (I expect the popup won't be shown), close browser and attach the log here?

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Log as requested

Comment 12

[Emilio Cobos Álvarez (:emilio)]

(just so it doesn't fall out the radar)

Comment 13

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Hm, from the log the popup is visible...looks like a rendering bug.

Please comment out gtk_widget_set_app_paintable() calls from nsWindow.cpp, rebuild and try again. You may see an empty popup after the click.

Comment 14

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1734819 [Linux] Make window transparency configurable, r?emilio

Comment 15

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1734819 [Linux] Make move-to-rect configurable, r?emilio

Comment 16

[Emilio Cobos Álvarez (:emilio)]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #13)

Please comment out gtk_widget_set_app_paintable() calls from nsWindow.cpp, rebuild and try again. You may see an empty popup after the click.

Nope, still no popup :/

However after forcing useMoveToRect to false, then I get the popup consistently.

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77902cd88a58
[Linux] Make window transparency configurable, r=emilio

Comment 19

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/77902cd88a58

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e204587ab6bc
[Linux] Make move-to-rect configurable, r=emilio

Comment 21

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 22

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e204587ab6bc

Comment 23

[Guo Yunhe]

I try to install this extension https://addons.mozilla.org/en-US/firefox/addon/surfshark-vpn-proxy/

But the popup never shows. I still cannot install this extension.

I tried a couple of extensions. Never succeed.

Firefox 93 on openSUSE Tumbleweed KDE Wayland.

Comment 24

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

(In reply to Guo Yunhe from comment #23)

I try to install this extension https://addons.mozilla.org/en-US/firefox/addon/surfshark-vpn-proxy/

But the popup never shows. I still cannot install this extension.

I tried a couple of extensions. Never succeed.

Firefox 93 on openSUSE Tumbleweed KDE Wayland.

Can you try Firefox 94 and latest nightly?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems?rd=Bug_info_Firefox#Testing_Mozilla_binaries
Thanks.

Comment 25

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:spohl, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Comment 26

[Emilio Cobos Álvarez (:emilio)]

Seems to work consistently now.