1734824 - "Firefox Translations" is slowing down Nightly on Bugzilla advanced search page

Status: RESOLVED WONTFIX

(Firefox :: Translations, defect)

Description

[Marco Castelluccio [:marco]]

I get the slow warning consistently on the edit page of complex Bugzilla searches.

Comment 1

[Florian Quèze [:florian]]

Do you have a profile of the slow down? (I couldn't reproduce)

Comment 2

[Marco Castelluccio [:marco]]

https://share.firefox.dev/30a7YPZ

Comment 3

[Florian Quèze [:florian]]

Thanks! Here's the relevant part of the profile: https://share.firefox.dev/3lqoVOl

Most of the time is spent in getTranslationNodes calling itself recursively, and calling includes(). My guess is the time is spent at https://searchfox.org/mozilla-central/rev/477950cf9ca9c9bb5ff6f34e0d0f6ca4718ea798/browser/extensions/translations/extension/dom-translation-content-script.js#1835 and seenTranslationNodes should be a set rather than an array.

Comment 4

[André Natal]

Thanks for pointing that out. We are going to deprecate this version soon and replace by a new one more polished

Comment 5

[Marco Castelluccio [:marco]]

André what is the timing there? I'm trying to gauge whether I should disable the extension for now and re-enable after a new version is released.

Comment 6

[André Natal]

We might have a replacement version by mid-january.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:florian, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 8

[André Natal]

Hi Marco,

we have a candidate version here [1] that I just tested in the page referenced [2] and it worked well for me without hangs. Could you test it when you have a chance, please?

To test it:

• first disable the in-tree extension : extensions.translations.disabled to false
• enable experiments: extensions.experiments.enabled to true
• then install the addon [1] via about:debugging

If this works for you, I can replace the current version by the refactored one.

[1] https://github.com/mozilla/firefox-translations/actions/runs/1460900159

[2] https://bugzilla.mozilla.org/query.cgi?bug_status=__open__&f1=OP&f10=CP&f11=regressed_by&f12=regressed_by&f13=creation_ts&f14=keywords&f15=reporter&f16=longdesc&f17=status_whiteboard&f2=cf_has_regression_range&f3=OP&f4=keywords&f5=OP&f6=blocked&f7=dependson&f8=CP&f9=CP&include_fields=blocks&include_fields=depends_on&include_fields=assigned_to&include_fields=creator&include_fields=creation_time&include_fields=cf_has_regression_range&include_fields=id&include_fields=summary&include_fields=groups&j1=OR&j5=OR&list_id=15862570&n12=1&n16=1&o11=isempty&o12=changedafter&o13=greaterthan&o14=nowords&o15=nowords&o16=casesubstring&o17=notsubstring&o2=equals&o4=casesubstring&o6=isnotempty&o7=isnotempty&product=Core&product=DevTools&product=External%20Software%20Affecting%20Firefox&product=Firefox&product=Firefox%20for%20Android&product=Firefox%20for%20iOS&product=Firefox%20Build%20System&product=NSPR&product=NSS&product=Remote%20Protocol&product=Testing&product=Toolkit&product=WebExtensions&query_format=advanced&v12=1970-01-01&v13=2021-09-08%2000%3A00%3A00%2B00%3A00&v14=regressionwindow-wanted&v15=intermittent-bug-filer%40mozilla.bugs&v16=since%20this%20bug%20is%20a%20regression%2C%20could%20you%20fill%20%28if%20possible%29%20the%20regressed_by%20field&v17=%5Bno-nag%5D&v2=yes&v4=regression

Comment 9

[Marco Castelluccio [:marco]]

It works for me!

Comment 10

[Marco Castelluccio [:marco]]

The addon was retired.