1734984 - sender.url of the message sent at document_start is the previous page URL in this tab

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P1)

Description

[wOxxOm]

Attachment: test-ff-ext.zip

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.71 Safari/537.36

Steps to reproduce:

1. install the attached extension
2. open a new tab, open devtools console
3. paste-and-go to https://thumbs3.imagebam.com/23874/626770238732222.jpg
4. Press the back button, then forward button

Repeat the last step several times and look in devtools console

Actual results:

Console occasionally prints BAD: about:newtab

Expected results:

Console prints GOOD

Comment 1

[wOxxOm]

Bisected to https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ede86e9e&tochange=a2d4c087
Suspecting https://hg.mozilla.org/integration/autoland/rev/3bd81b9fb804f7d572c0849ebd17da07add17e1c
Description: "Bug 1729395 - Handle message sender going away during message processing r=robwu"

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'WebExtensions::Untriaged' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[wOxxOm]

FWIW, since content scripts don't rerun with BFCache + fission (bug 1734991), it hides this particular bug in newer FF so a more universal STR would need to force-disable bfcache somehow.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1729395

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Tomislav, ois that something that should be fixed and uplifted to beta/release or is that something that can ride the 95 train? (asking because of P1/S2 status)

Comment 6

[Tomislav Jovanovic :zombie]

I'm working on this with the intention of uplifting. It's not the end of the world if we don't get it, but I would like to.

Comment 7

[Tomislav Jovanovic :zombie]

Attachment: Bug 1734984 - Use WindowGlobalParent.documentURI for sender.url r=robwu

Comment 8

[Tomislav Jovanovic :zombie]

While trying to write a minimal regression test for this bug, I could only reproduce it when navigating to an image. Did you see any other circumstances under which this bug is manifested?

Comment 9

[Tomislav Jovanovic :zombie]

Changing the severity according to new finding of limited scope of the bug.

Comment 10

[wOxxOm]

So far only with an image.

Comment 11

[wOxxOm]

Somehow the bugtracker gave me the rights to reassign the severity :-)

Comment 12

[Tomislav Jovanovic :zombie]

Thanks for the confirmation.

(In reply to Pascal Chevrel:pascalc from comment #5)

Tomislav, ois that something that should be fixed and uplifted to beta/release or is that something that can ride the 95 train? (asking because of P1/S2 status)

Given the new info, and since this bug has already shipped in 93, I will not be asking for uplifts here, this can ride 95 to release.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ded3930cc57d
Use WindowGlobalParent.documentURI for sender.url r=robwu

Comment 14

[Alexandru Michis [:malexandru]]

Backed out changeset ded3930cc57d (Bug 1734984) for causing bc failures in browser_ext_contentscript_sender_url.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/528c3399317b8878d44cb7519e24d4d5a6f109d5
Push with failures, failure log.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6961dc913ccb
Use WindowGlobalParent.documentURI for sender.url r=robwu

Comment 16

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_ext_contentscript_sender_url.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/dc0df481767a1f7e0882ae7645419c1ec9ba8fa7
Log link: https://treeherder.mozilla.org/logviewer?job_id=355319604&repo=autoland&lineNumber=3590

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55a504b8e617
Use WindowGlobalParent.documentURI for sender.url r=robwu

Comment 18

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/55a504b8e617