1735047 - browserSettings.zoomSiteSpecific.set does not call ExtensionPreferencesManager.setSetting

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P3)

Description

[dw-dev]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

Installed Zoom Page WE extension. Depending on the options configured in Zoom Page WE Options, the 'browser.zoom.siteSpecific' preference may be set to 'false'.

Actual results:

When Zoom Page WE is disabled or uninstalled, the 'browser.zoom.siteSpecific' preference remains set to 'false'.

Expected results:

When Zoom Page WE extension is disabled or uninstalled, the 'browser.zoom.siteSpecific' preference should be reset to 'true' (the normal default value).

Comment 1

[dw-dev]

The browser.browserSettings.zoomSiteSpecific.set API should be changed to call ExtensionPreferencesManager.setSetting.

Similarly, the browser.browserSettings.zoomFullPage.set API should be changed to call ExtensionPreferencesManager.setSetting.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'WebExtensions::Untriaged' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[dw-dev]

Please can you assign this bug to me.

I am the developer of the Zoom Page WE extension and I implemented the browserSettings.zoomFullPage and browserSettings.zoomSiteSpecific APIs.

I already have a tested patch that fixes this bug.

Comment 4

[Tomislav Jovanovic :zombie]

Sure dw-dev, thank you.

I think just submitting a patch on Pahbricator will assign you automatically, but I'll do it now.

If you'd like editbugs permission, please follow these steps, happy to vouch for you: https://wiki.mozilla.org/BMO/UserGuide#How_to_apply_for_upgraded_permissions

Comment 5

[dw-dev]

Attachment: Bug 1735047 - Validate extension setting values for zoom settings; r?mixedpuppy

• browser.browserSettings.zoomSiteSpecific.set() now calls ExtensionPreferencesManager.setSetting().
• browser.browserSettings.zoomFullPage.set() now calls ExtensionPreferencesManager.setSetting().

Comment 6

[dw-dev]

Shane, Please can you add a "testing-approved" tag to this patch in Phabricator, so that it can land in Lando. I tried adding this tag, which appeared to work, but was then rejectd by Herald.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f03d181a0b42
Validate extension setting values for zoom settings; r=mixedpuppy

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f03d181a0b42