1735077 - "checked" attribute from <input type="checkbox" disabled checked> no longer works

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[dukevinjduke]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:95.0) Gecko/20100101 Firefox/95.0

Steps to reproduce:

Create an HTML element with
<input type="checkbox" disabled checked>
The checkbox does not respect the "checked" attribute unlike in Firefox stable channel and Chrome/Edge.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=340719f2946c85bb8df494cb4740129e5a5078af&tochange=6d22ab00f3133b6760ebca3943dba097eff853c7

Comment 3

[Alice0775 White]

input type="radio" is also affected.
data:text/html,<input type="radio" name="aa" disabled checked>

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Nice catch :)

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1735077 - Fix rendering of <input type=checkbox/radio disabled checked>. r=mstange,#layout-reviewers

The simplification in bug 1734115 missed this case.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e92568e4216
Fix rendering of <input type=checkbox/radio disabled checked>. r=jwatt

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31186 for changes under testing/web-platform/tests

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8df1cd9300e4
Don't change indeterminate radio rendering, as that's apparently a thing.

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/6e92568e4216
https://hg.mozilla.org/mozilla-central/rev/8df1cd9300e4

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9245221 [details]
Bug 1735077 - Fix rendering of <input type=checkbox/radio disabled checked>. r=mstange,#layout-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Regression from bug 1734115 which we want on beta.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very simple fix to non-native checkbox-drawing codepath.
• String changes made/needed: none

Comment 12

[Dianna Smith [:diannaS]]

Comment on attachment 9245221 [details]
Bug 1735077 - Fix rendering of <input type=checkbox/radio disabled checked>. r=mstange,#layout-reviewers

Approved for 94.0b6

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/179d9722b0d7
https://hg.mozilla.org/releases/mozilla-beta/rev/79e03f50e898