1735131 - (Puppeteer) JavaScript error: chrome://remote/content/cdp/observers/ContextObserver.jsm, line 137: TypeError: can't access property "docShell", window is null

Status: RESOLVED FIXED

(Remote Protocol :: CDP, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

When I run several Puppeteer tests locally I can see the following Javascript error in the console:

JavaScript error: chrome://remote/content/cdp/observers/ContextObserver.jsm, line 137: TypeError: can't access property "docShell", window is null

It's coming from our context observer when handling the document-element-inserted notification.

Interestingly I do not see this failure when running our browser chrome tests.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The cases when the window is null are actually happening because Puppeteer tests are loading pages that contain a textarea. The other document that gets inserted and causes the notification to be fired here is a SVG, specifically the resizer for the textarea field with the URL: chrome://global/skin/icons/resizer.svg.

As such we have to ignore all the events that do not have a valid window attached.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1735131 - [remote] Ignore "document-element-inserted" notifications without a window object.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1601245

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c98c980f2de
[remote] Ignore "document-element-inserted" notifications without a window object. r=webdriver-reviewers,jdescottes

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/0c98c980f2de