Closed Bug 1735184 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31190 - Don't proceed with same-document history traversals if the destination entry is no longer in the back/forward list

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox95 fixed)

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31190 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31190
Details from upstream follow.

Nate Chapin <japhet@chromium.org> wrote:

Don't proceed with same-document history traversals if the destination entry is no longer in the back/forward list

This fix will apply only if AppHistory is enabled, but will apply to
all preempted same-document history traversals, even if AppHistory
hasn't been used at all by the page. AppHistory has the requisite
state to detect this case, but the rest of the renderer navigation
logic does not.

Bug: 1256622
Change-Id: I481067e6e02b61468d604dafcce962a62439a3f8

Reviewed-on: https://chromium-review.googlesource.com/3206547
WPT-Export-Revision: 32fb7943461abccad8525530cf864e6db4628eec

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS : 1
FAIL : 1

Chrome

OK : 1
CRASH: 1
FAIL : 1

Safari

OK : 2
PASS : 1
FAIL : 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/app-history/navigate/forward-to-pruned-entry.html
If forward pruning clobbers the target of a traverse, abort: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/15ff2f426049 [wpt PR 31190] - Don't proceed with same-document history traversals if the destination entry is no longer in the back/forward list, a=testonly https://hg.mozilla.org/integration/autoland/rev/aebccb417b4d [wpt PR 31190] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.