Add dummy tab routines to SeaMonkey mailnews tab browser.
Categories
(SeaMonkey :: MailNews: General, task)
Tracking
(seamonkey2.53+ fixed)
People
(Reporter: frg, Assigned: frg)
Details
(Whiteboard: SM2.53.10)
Attachments
(1 file)
|
1.24 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
tabmail.xml extends tabbrowser.xml. Some code references unimplemented functions for tabmail.xml.
Looking at the tabbrowser code referencing it I think we can get away with implementing _getTabForContentWindow and getBrowserIndexForDocument as dummies. Didn't notice any problems for several weeks in 2.53.10b1 pre doing so.
PS. Thought there was an old bug already but didn't find it.
|
Assignee | |
Comment 1•3 years ago
|
||
[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: console errors when opening mailnews
Testing completed (on m-c, etc.): 2.53.10b1 pre
Risk to taking this patch (and alternatives if risky): dummy implenetation broken before.
String changes made by this patch: --
Comment on attachment 9245349 [details] [diff] [review]
1735243-undefinedbrowseri-25310.patch
[Triage Comment]
Seems to be okay r/a=me
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/dd9893914573
Fix undefined browser[i] console error in mailnews. r=IanN
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 4•3 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/32e366455d10d8f4e8c822553bb93e21b222c01e
Fix undefined browser[i] console error in mailnews. r=IanN a=IanN
Description
•