1735266 - don't potentially create a document where none existed in CollectFrameTreeData

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Timothy Nikkel (:tnikkel)]

See explanation at https://bugzilla.mozilla.org/show_bug.cgi?id=1725569#c18
Short version: the GetDoc call in CollectFrameTreeData creates a doc if none existed.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1735266. Call GetExtantDoc instead of GetDoc in CollectFrameTreeData so we don't potentially create a doc where non existed before. r?farre,kashav,annyG

See https://bugzilla.mozilla.org/show_bug.cgi?id=1725569#c18 for how this causes a test to fail.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b94ac1d5d704
Call GetExtantDoc instead of GetDoc in CollectFrameTreeData so we don't potentially create a doc where non existed before. r=farre

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b94ac1d5d704

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval.

Comment 5

[Timothy Nikkel (:tnikkel)]

Comment on attachment 9245391 [details]
Bug 1735266. Call GetExtantDoc instead of GetDoc in CollectFrameTreeData so we don't potentially create a doc where non existed before. r?farre,kashav,annyG

Beta/Release Uplift Approval Request

• User impact if declined: needed for bug 1725569
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): small change to session store code to not create a doc accidentally when getting a doc
• String changes made/needed: none

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9245391 [details]
Bug 1735266. Call GetExtantDoc instead of GetDoc in CollectFrameTreeData so we don't potentially create a doc where non existed before. r?farre,kashav,annyG

Approved for 94.0b6

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a593adb38a74

Comment 8

[Timothy Nikkel (:tnikkel)]

Comment on attachment 9245391 [details]
Bug 1735266. Call GetExtantDoc instead of GetDoc in CollectFrameTreeData so we don't potentially create a doc where non existed before. r?farre,kashav,annyG

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: needed for uplift of bug 1725569
• User impact if declined: user impact is from bug 1725569
• Fix Landed on Version: 95
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): small change to session store code to not create a doc accidentally when getting a doc
• String or UUID changes made by this patch: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9245391 [details]
Bug 1735266. Call GetExtantDoc instead of GetDoc in CollectFrameTreeData so we don't potentially create a doc where non existed before. r?farre,kashav,annyG

Approved for 91.3esr.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/bc409de84a53