1735309 - FIPS-mode crashes neqo

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Dragana Damjanovic [:dragana]]

SUSE is currently having the following problem with FF91esr: When run in FIPS-mode, Firefox crashes in neqo.
As it turns out the call to hkdf::import_key(TLS_VERSION_1_3, cipher, salt) in new_initial() in third_party/rust/neqo-transport/src/crypto.rs fails, because it tries to create a key from raw key material, which is apparently not allowed in FIPS-mode.

Comment 1

[Dragana Damjanovic [:dragana]]

This is fixed in PR 1247.

This bug will create a patch for FF91.

Comment 2

[Dragana Damjanovic [:dragana]]

Attachment: Use PK11_ImportDataKey for FIPS safety

Comment 3

[Dragana Damjanovic [:dragana]]

[Tracking Requested - why for this release]: This patch is only needed for esr91. see the description.

Comment 4

[Dragana Damjanovic [:dragana]]

Comment on attachment 9245438 [details]
Use PK11_ImportDataKey for FIPS safety

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: SUSE is currently having the following problem with FF91esr: When run in FIPS-mode, Firefox crashes in neqo.
• User impact if declined:
• Fix Landed on Version: 93
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String or UUID changes made by this patch:

Comment 5

[Dragana Damjanovic [:dragana]]

Martin, can you please add some text about the risk for this uplift (see comment 4). I am not familiar with nss well enough to write this. Thanks.

Comment 6

[Martin Thomson [:mt:]]

Risks: This change swaps out the use of one API for an equivalent function that doesn't crash when FIPS is enabled. This is a small amount of changed code, but the functions that are being used are extremely widely used (we use this API for every TLS connection) and the code around this is very thoroughly tested.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please link this bug to the Neqo update bug containing this fix for m-c as well.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9245438 [details]
Use PK11_ImportDataKey for FIPS safety

Approved for 91.3esr.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/c568ed428f75

Comment 10

[Dragana Damjanovic [:dragana]]

The fix landed in m.c. in bug 1733603.