1735341 - Rename FillVectorWithICUCall to FillBufferWithICUCall

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Rename FillVectorWithICUCall to FillBufferWithICUCall to make it an overloading method of FillBufferWithICUCall with the buffer type is Mozilla::Vector,
So the caller could use Mozilla::Vector as the buffer, instead of creating some buffer adapter on its own, like nsTArrayU8Buffer

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1735341 : Rename FillVectorWithICUCall to FillBufferWithICUCall.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/517b566a350a
Rename FillVectorWithICUCall to FillBufferWithICUCall. r=platform-i18n-reviewers,anba,dminor

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing build bustages on Locale.cpp. CLOSED TREE
Backout link : https://hg.mozilla.org/integration/autoland/rev/c67cec98bf16173efd69cff2f12d1ffbb09c907f
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=517b566a350ab4b8ab77c1b1c34b28f3365e99fa&selectedTaskRun=MQRSUasRSLGGnr59D7ohlQ.0
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=354688439&repo=autoland&lineNumber=14681

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Need to rebase on Bug 1719746.
https://hg.mozilla.org/integration/autoland/rev/4fa55bded471

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

try after rebase on bug 1719746: https://treeherder.mozilla.org/jobs?repo=try&revision=5cb329b1ecfcd1a74f6b8cec0881339cb02d0bfb&selectedTaskRun=X7YRe4gWSFmxsFV6mwVC_Q.0

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1b3e7dec7e2
Rename FillVectorWithICUCall to FillBufferWithICUCall. r=platform-i18n-reviewers,anba,dminor

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/f1b3e7dec7e2

Comment 8

[Atila Butkovits]

Backout link: https://hg.mozilla.org/integration/autoland/rev/39312476e05fd29b0361d2be4b0bdc907d35c8e2

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This got backed out because bug 1719746 got backed out for causing crashes in debug builds.

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

My patch is just doing the renaming, and it doesn't depend on bug 1719746,
I'll update my patch and re-land it.

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

try : https://treeherder.mozilla.org/jobs?repo=try&revision=ae668508337d7c446d2fa667d7a8f120877781c0

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd6b374f323e
Rename FillVectorWithICUCall to FillBufferWithICUCall. r=platform-i18n-reviewers,anba,dminor

Comment 13

[Andra Esanu (needinfo me)]

(In reply to Cristina Cozmuta (:CrissCozmuta) from comment #3)

Backed out for causing build bustages on Locale.cpp. CLOSED TREE
Backout link : https://hg.mozilla.org/integration/autoland/rev/c67cec98bf16173efd69cff2f12d1ffbb09c907f
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=517b566a350ab4b8ab77c1b1c34b28f3365e99fa&selectedTaskRun=MQRSUasRSLGGnr59D7ohlQ.0
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=354688439&repo=autoland&lineNumber=14681

== Change summary for alert #31893 (as of Fri, 15 Oct 2021 11:08:02 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
5%	displaylist_mutate	macosx1015-64-shippable-qr	e10s stylo webrender	1,779.77 -> 1,874.44
4%	displaylist_mutate	macosx1015-64-shippable-qr	e10s stylo webrender-sw	1,797.40 -> 1,875.55
4%	displaylist_mutate	macosx1015-64-shippable-qr	e10s stylo webrender-sw	1,799.11 -> 1,876.42

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=31893

Comment 14

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/dd6b374f323e