1735347 - TypeError: data is undefined

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P1)

Description

[kernp25]

Attachment: firefox_VlXnqIfduB.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0

Actual results:

The error shows in the console after the update (95.0a1 (2021-10-12) (64-Bit)).

Comment 1

[Tomislav Jovanovic :zombie]

I can't reproduce this, do you have some reliable steps?

Comment 2

[Tomislav Jovanovic :zombie]

Also is anything related to any extensions broken? Some extension functionality, popups, sidebars, etc?

Comment 3

[Tomislav Jovanovic :zombie]

Attachment: Bug 1735347 - Add fallback and some diagnostic reporting for getting FrameData r?robwu

Same fallback for getting FrameData using sync message existed prior to D127750:

https://searchfox.org/mozilla-central/rev/7e36862b61/toolkit/components/extensions/ExtensionPageChild.jsm#595

I dropped it thinking it might not be needed anymore, but looks like it is,
and I'm adding some diagnostic error reporting to figure out when/why.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d36cd20249a
Add fallback and some diagnostic reporting for getting FrameData r=robwu

Comment 5

[Tomislav Jovanovic :zombie]

This could be a regression from bug 1708243, still no clear, but additional diagnostics might help us figure it out.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8d36cd20249a

Comment 7

[Tomislav Jovanovic :zombie]

I would still like to investigate if this needs further fixes once we hear from the reporter.

Comment 8

[Tomislav Jovanovic :zombie]

Kernp, can you please test the latest Nighty, what exact error does it reports that starts with FrameData missing for ...?

Also, can you try this build from Try, that doesn't include Part 4 from bug 1708243, but includes the same diagnostics from this bug, and confirm it reports a similar error in the same circumstances?

https://treeherder.mozilla.org/jobs?repo=try&revision=4fe09440f73156342e46a5fe5afb9bca5e79f8e2&selectedTaskRun=FDQZkNx7TYetW1gZT-Ky4w.0
(click on the Artifacts tab in the lower half, and get either setup.exe or target.zip depending on your preference).

Comment 9

[kernp25]

(In reply to Tomislav Jovanovic :zombie from comment #1)

do you have some reliable steps?

Not really :(

Also, can you try this build from Try, that doesn't include Part 4 from bug 1708243, but includes the same diagnostics from this bug, and confirm it reports a similar error in the same circumstances?

I will try!

It happens with these add-ons (and maybe more):
https://addons.mozilla.org/firefox/addon/cyberghost-vpn-free-proxy/
https://addons.mozilla.org/firefox/addon/yahoo-mail-notifier-we/
https://addons.mozilla.org/firefox/addon/tab-unloader-we/
https://addons.mozilla.org/firefox/addon/ublock-origin/

The uri.spec of the Stay secure with CyberGhost VPN Free Proxy add-on: moz-extension://5661d294-6127-4f2c-b43d-4f5260ff528b/cyberghost.html

In the manifest.json of the add-on:

 "browser_action": {
      "default_icon": "cyberghost_disabled.png",
      "default_popup": "cyberghost.html"
   },

The uri.spec of the Yahoo! Mail Notifier add-on: moz-extension://303f57d1-bc79-4bb4-819e-afd1c2043556/popup.html

In the background.js of the add-on:

browser.browserAction.setPopup({ popup: "popup.html" });

The uri.spec of the Tab Unloader add-on: moz-extension://a5e9498e-e6c1-4adc-855b-ce93b58171ca/html/popup.html

In the manifest.json of the add-on:

  "browser_action": {
    "default_title": "Tab Unloader",
    "theme_icons": [{
      "light": "images/icon-dark.svg",
      "dark": "images/icon.svg",
      "size": 32
    }],
    "default_popup": "html/popup.html",
    "browser_style": true
  },

The uri.spec of the uBlock Origin add-on: moz-extension://2b7a776e-f3bf-4cbf-8c93-e59ed3b1a070/popup-fenix.html

In the manifest.json of the add-on:

  "browser_action": {
    "browser_style": false,
    "default_icon": {
      "16": "img/icon_16.png",
      "32": "img/icon_32.png"
    },
    "default_popup": "popup-fenix.html",
    "default_title": "uBlock Origin"
  },

Comment 10

[kernp25]

Attachment: firefox_pLGjp35kmH.png

Comment 12

[Tomislav Jovanovic :zombie]

Attachment: Bug 1735347 - Use process MessageManager for FrameData r=robwu

Preloading popups on hover involves swapping FrameLoaders, which might be
messing with frame MessageManagers, so use the process message manager instead.

Comment 13

[Chris Peterson [:cpeterson]]

Tomislav, do you plan to uplift this fix and framescripts bug 1708243 Part 4 to Beta 94?

Comment 14

[kernp25]

(In reply to Tomislav Jovanovic :zombie from comment #8)

Also, can you try this build from Try, that doesn't include Part 4 from bug 1708243, but includes the same diagnostics from this bug, and confirm it reports a similar error in the same circumstances?

I tested it for a while and it seems, it does NOT trigger this error with this build.

The firefox_pLGjp35kmH.png attachment was not from this build.

Comment 15

[kernp25]

Attachment: oQxk1pLUQy.mp4

How to reproduce the bug.

Comment 16

[kernp25]

(In reply to Tomislav Jovanovic :zombie from comment #1)

I can't reproduce this, do you have some reliable steps?

Maybe the attached video will help?

Comment 17

[Tomislav Jovanovic :zombie]

(In reply to Chris Peterson [:cpeterson] from comment #13)

Tomislav, do you plan to uplift this fix and framescripts bug 1708243 Part 4 to Beta 94?

I'm still to figure out the cause here, and it seems too late and too risky to be uplifting something like this, so I'll let this and bug 1708243 Part 4 ride the 95 to release.

Comment 18

[Chris Peterson [:cpeterson]]

(In reply to Tomislav Jovanovic :zombie from comment #17)

I'm still to figure out the cause here, and it seems too late and too risky to be uplifting something like this, so I'll let this and bug 1708243 Part 4 ride the 95 to release.

SGTM. In that case, I will set status-firefox94=wontfix.

Comment 19

[Mathew Hodson]

The first part of bug 1708243 landed in Firefox 93. I don't think earlier releases are affected.

Comment 20

[Pascal Chevrel:pascalc]

This looks fixed to me in 95, isn't it?

Comment 21

[Rob Wu [:robwu]]

The regression got fixed in 95 by https://hg.mozilla.org/mozilla-central/rev/8d36cd20249a

There is a follow-up task to investigate the issue and resolve the root cause, but that could be done in a follow-up bug.

Comment 22

[erosman [:erosman]]

FrameData missing for ...? error still present in 96.0a1 (2021-11-23) (64-bit)

Comment 23

[Mathew Hodson]

Since the patch landed in Firefox 95, could you close the bug as fixed so the status is clear?

If there is follow up work, that should be tracked in a separate bug.

Comment 24

[Tomislav Jovanovic :zombie]

After the fallback in D128310, untangling this from bug 1735899, and testing after Fission was rolled out to everyone in Firefox 96, i believe this is only happening when we rapidly create and destroy <browser>s for the popup in anticipation of a click on a browser action. By the time the child process asks for FrameData, the browser is already being torn down in the parent, so no answer arrives. This is similar to the warning from layout we get while scrubbing the mouse over browser actions buttons without clicking:

Layout was forced before the page was fully loaded. If stylesheets are not yet loaded this may cause a flash of unstyled content.

Unless anyone has actual issues of extension popups not actually working still, I'm closing this as fixed. The warning is still here, but possibly only because we added explicit code to log the error in such cases, these conditions were probably happening before bug 1708243, only hidden behind the || {} fallback.

I never see the warning in one of my profiles, and in the other only after I spend 10+ seconds of moving my mouse over (multiple) browser. If the warning is too common for others, please open a separate bug to consider dropping it.

Comment 25

[erosman [:erosman]]

Attachment: bug1735347.jpg

97.0a1 (2021-12-20) (64-bit)
There is a new error

NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIDocShell.domWindow]
window-global.js:421

Comment 26

[Tomislav Jovanovic :zombie]

Does it impact the functionality of an extension popup?

That seem related to devtools, and not to this bug, though the root cause could be similarly related to those browsers being torn down.

Comment 27

[erosman [:erosman]]

Does it impact the functionality of an extension popup?

I haven't noticed any issues with the extension popup.
The error comes up on toolbar icon mouseover as was the situation with the error in this bug. I posted the comment for information only.