1735414 - irc and ircs actions in about:preferences do not appear correctly when browser.download.improvements_to_download_panel is true

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[kpatenio]

Attachment: missing_always_ask_ircs.mov

[Reproduction steps]

1. Enable browser.download.improvements_to_download_panel in about:config
2. Go to about:preferences
3. See that "Always ask" does not appear for content types irc and ircs

Happens when starting a new profile, but can also happen with existing profiles. Switching pref back to false and refreshing about:preferences will show "Always ask" again as expected.

This issue can technically be easily resolved by manually setting a preferred action for either content type, but it may be worth looking into so that the actions appear as expected for new profiles/new users.

Comment 1

[kpatenio]

This might be of interest for this issue: https://searchfox.org/mozilla-central/rev/d37daf2f82ed22b6a2a5cbbb975423825dfd69fa/uriloader/exthandler/HandlerService.js#533

Comment 2

[:Gijs (he/him)]

Nice find!

Based on logs, I expect this is related to the unit test failures that Molly has been looking at.

If I had to guess, the issue is that we're now (after bug 1733492) initializing alwaysAskBeforeHandling to false for new mimeinfo objects - but despite the "mime info" in the name, these also get used for protocol handler information. For protocol handlers, we should continue to default to "always ask". I guess at https://searchfox.org/mozilla-central/rev/d37daf2f82ed22b6a2a5cbbb975423825dfd69fa/uriloader/exthandler/nsMIMEInfoImpl.cpp#90 this should be conditional on aClass being eMIMEInfo. That might also fix the automated test Molly was looking at.

Comment 3

[Micah [:mtigley] (she/her)]

Attachment: Bug 1735414 - Protocol handlers should be set to always ask before handling. r=mhowell,Neil

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b14118c372d
Protocol handlers should be set to always ask before handling. r=mhowell,NeilDeakin

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6b14118c372d

Comment 6

[Anca Soncutean, Desktop QA]

Reproduced with Fx 95.0a1 (2021-10-10) on Windows 10.
Verified fixed with Fx 96.0a1 (2021-11-02) and Fx 95.0b1 on Windows 10, macOS 11 and Ubuntu 18.04.