1735457 - about:welcome: aria-description on colorways variation radio buttons isn't useful and is confusing in NVDA browse mode

Status: RESOLVED WONTFIX

(Firefox :: Messaging System, defect, P2)

Description

[James Teh [:Jamie]]

STR (with the NVDA screen reader):

1. Go to about:welcome
2. Press "Get started", then skip import with "Not now".
3. Press control+home to move to the top of the document.
4. Press down arrow 4 times to move to the radio button to explore abstract colorways.
5. Press space to select it.
6. Press down arrow until NVDA says "Abstract".
7. Press down arrow again.
   • Expected: NVDA should say "radio button checked". (The label is on the next line because its text is visible.)
   • Actual: NVDA says "radio button checked Use this colorway"

First, I don't think the "Use this colorway" text really offers anything useful to the user, yet it gets repeated for each option.

Second, the label is visible, so NVDA doesn't report the label on the radio button itself in favour of the text of the actual label. That means that the aria-description ("Use this colorway") gets reported first.

I think the correct fix here is to remove aria-description from the l10n strings. That's probably not feasible at this point. However, we can probably just remove the data-l10n-attrs attribute, since I guess aria-description isn't in the builtin list of attributes to be localised (yet).

Comment 1

[Ed Lee :Mardak]

The incoming designs for new colorways screens currently don't have variation selections, so we might be able to reuse the regular theme component and delete the colorway one

https://www.figma.com/file/2TrMkNefxzhMCXjUqM8KIy/Onboarding?node-id=2510%3A48746

Comment 2

[Hanna Alemu [:hanna_a]]

@Ed does it still make sense to fix this bug in that case? Or should we still fix it to support older Fx versions (Before 96) ?

Comment 3

[Ed Lee :Mardak]

We wouldn't uplift something to 96. Typically at most to the current release branch, which is now 102 and does not show colorway. We could reuse this bug to delete the Colorways component (and related strings with aria, etc.) if we indeed can reuse the Themes component.

Comment 4

[Hanna Alemu [:hanna_a]]

Attachment: WIP: Bug 1735457 - about:welcome: aria-description on colorways variation radio buttons isn't useful and is confusing in NVDA browse mode

Comment 5

[Punam Dahiya [:pdahiya]]

With Bug 1794485 fix, we are removing MR2 colorways which are no longer used in new and existing onboarding.