1735526 - Margins selection up/down arrows are not visible on print preview dialog, if you have a large system font size

Status: VERIFIED FIXED

(Toolkit :: Printing, defect)

Description

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: Screenshot from 2021-10-13 13-37-48 (1).png

Note

• Ubuntu 20.04 x64, Windows 10 x64 and macOS 10.15 not affected.

Affected versions

• Firefox 94.0b5
• Firefox 95.0a1
• Firefox 93.0

Affected platforms

• Ubuntu 16.04 x86

Steps to reproduce

1. Launch Firefox
2. Go to any random page (page not PDF (PDFs don't have margins to be set)).
3. Access the print preview page with Ctrl+ P.
4. In the new semi-modal printing UI, click on Margins drop-down and select any of the
   displayed options.

Expected result

• Selecting the Custom value from margins exposes options to modify margins.

Actual result

• The bottom and right margins could not be modified, because the up and down
  selection arrows are cut off from the print preview page .

Regression range

• I will come back with regression range ASAP.

Additional notes

• The issue is reproducible only on Ubuntu 16.04 x86.
• The issue can be seen in the attachment.

Comment 1

[Alice0775 White]

I can also reproduce the issue in Nightly84.0a1-95.0a1 Windows10(TEXT scale=140%, DPI scale=100%). (I can scroll the right pane horizontally to see the up/down arrow).
So, it seems not a resent regression.
It seems to depend on the system font size.
The print preview doesn't seem to take system font size into account. Just Fixed Layout :(

Comment 2

[Daniel Holbert [:dholbert]]

This looks like a bug in our frontend constraints here; the dialog doesn't account for the possibility that there may be a large font size which might make these input fields wider.

Reclassifying as Toolkit|Printing which I think is where we're tracking frontend bugs in the print preview dialog.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1735526 - Make print settings custom margins pane have a less fragile layout. r=mstriemer

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcbcf91ea151
Make print settings custom margins pane have a less fragile layout. r=mstriemer

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/dcbcf91ea151

Comment 6

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I can confirm this issue is fixed, I verified using Firefox 95.0a1 (latest nightly) on Ubuntu 16.04 x86, with 1920x1080 resolution and scale for menu and title bars: 1,12 and 1, the arrows are visible in margins settings layout.

Comment 7

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I can confirm this issue is fixed, I verified using Firefox 95.0b5 on Ubuntu 16.04 x86, with 1920x1080 resolution and scale for menu and title bars: 1,12 and 1.