Open Bug 1735556 Opened 4 years ago Updated 1 year ago

Overreporting of SVG image memory usage

Categories

(Core :: Graphics: ImageLib, defect)

defect

Tracking

()

Performance Impact none

People

(Reporter: mccr8, Unassigned)

References

Details

See bug 1721745, comment 11. It looks like ImageLib is overreporting memory for the SVG images in the Google Docs recording in TP6. Some recent changes to how we allocate processes has apparently caused the over reporting to get large enough to cause heap-unclassified to become negative, which causes asserts in the test and is also generally bad.

Can you look into this, Andrew? Thanks. (This is in lieu of the needinfo in bug 1721745, because I think for beta we can just hack around it by disabling the assertion.)

Flags: needinfo?(aosmond)

Jim, is there somebody who can work on this soon? Bug 1721745 is now frequently failing on mozilla-central, too, and it would be better if we could avoid disabling the assert, or at least try to not leave it disabled for long. Thanks.

Flags: needinfo?(jmathies)
Blocks: gfx-triage
Flags: needinfo?(jmathies)
No longer blocks: gfx-triage
Blocks: 1767048
Severity: -- → S3

Adding this to the Performance triage as the priority for this work is unclear.

Performance Impact: --- → ?

I don't know how much the performance triage people care about fine grained memory measurement issues like this.

The main impact here is that I had to disable an assertion in a memory reporting check (bug 1721745), which could possibly find regressions. That said, I haven't noticed any severe regressions in the last 19 months so it probably isn't a big deal from that perspective.

This could also possibly cause issues with accurately assessing the memory usage for a page that uses a ton of SVG, but I also haven't noticed many of those cases.

Performance Impact: ? → none
Flags: needinfo?(aosmond)
You need to log in before you can comment on or make changes to this bug.