Closed Bug 1735600 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31216 - [Legacy client hints modernization] (5) Check for `sec-ch-` in WebTests

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox95 fixed)

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31216 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31216
Details from upstream follow.

Ari Chivukula <arichiv@chromium.org> wrote:

[Legacy client hints modernization] (5) Check for sec-ch- in WebTests

This CL adds WebTests for the new names (with the sec-ch- prefix) of
the dpr, device-memory, width, and viewport-width client hints.

NOTE: This does not remove any existing hints, they will remain on by
default:
https://docs.google.com/document/d/1yhVLyEIpDhhDQf698WkvXBiPcLwxEgCBI4o1FjvXwfM/edit

This series of CLs seeks to add sec-ch- prefixes to client hints that
are missing them by deprecating the old versions and adding new ones:
(1) Add sec-ch- hint constants
(2) Add feature to gate legacy hints for future deprecation
(3) Implement sec-ch- device-memory, dpr, width, and viewport-width
(4) Enable sec-ch- client hints by default
(5) Check for sec-ch- in WebTests
(6) Add deprecation issue for legacy hints

COMMIT=false
Bug: 1227043

Change-Id: I3065ac322ba2b99426b81942c13fb8014c1ece58
Reviewed-on: https://chromium-review.googlesource.com/3221278
WPT-Export-Revision: dadef3e21093e79a7351e88bd1c7b562c20d1881

PR 31216 applied with additional changes from upstream: 207e223d74fdc1f1103101d47105102fab667b4b

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 44 tests and 1 subtests

Status Summary

Firefox

OK : 44
PASS : 65
FAIL : 26

Chrome

OK : 44
PASS : 56
FAIL : 35

Safari

OK : 36
PASS : 62
FAIL : 21
TIMEOUT: 16

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/client-hints/accept-ch-answers.sub.https.html
Accept-CH header test: FAIL (Chrome: FAIL, Safari: FAIL)
/client-hints/accept-ch-change.https.html
Accept-CH changes based on header: FAIL (Chrome: FAIL, Safari: TIMEOUT)
/client-hints/accept-ch-stickiness/cross-origin-iframe-redirect-with-fp-delegation.https.html
Iframe redirect with Feature Policy delegation got client hints according to expectations.: FAIL (Chrome: FAIL, Safari: FAIL)
/client-hints/accept-ch-stickiness/cross-origin-navigation.https.html
cross origin navigation got client hints according to expectations.: FAIL (Chrome: FAIL, Safari: FAIL)
/client-hints/accept-ch-stickiness/cross-origin-subresource-redirect-with-fp-delegation.https.html
cross-origin subresource redirect with Feature Policy delegation got client hints according to expectations.: FAIL (Chrome: FAIL, Safari: FAIL)
/client-hints/accept-ch-stickiness/cross-origin-subresource-with-feature-policy.https.html
cross origin subresources authorized by FP gets it own resources got client hints according to expectations.: FAIL (Chrome: FAIL, Safari: FAIL)
/client-hints/accept-ch-stickiness/same-origin-navigation-no-accept-ch.https.html
empty-ch on navigation got client hints according to expectations.: FAIL (Chrome: FAIL, Safari: FAIL)
/client-hints/accept-ch-stickiness/same-origin-navigation-redirect.https.html
redirect on navigation got client hints according to expectations.: FAIL (Chrome: FAIL, Safari: FAIL)
/client-hints/accept-ch-stickiness/same-origin-navigation.https.html
same origin navigation got client hints according to expectations.: FAIL (Chrome: FAIL, Safari: FAIL)
/client-hints/accept-ch-stickiness/same-origin-subresource-redirect-opted-in.https.html
same-origin subresource redirect with opt-in got client hints according to expectations.: FAIL (Chrome: FAIL, Safari: FAIL)
/client-hints/accept-ch-feature-policy-navigation.https.html
Client hints loaded on cross-origin iframe request with feature policy.: FAIL (Chrome: FAIL, Safari: FAIL)
Client hints loaded on same-origin iframe request with feature policy.: FAIL (Chrome: FAIL, Safari: FAIL)
Client hints loaded on cross-origin iframe request with feature policy after attempting to set independently.: FAIL (Chrome: FAIL, Safari: FAIL)
/client-hints/accept-ch-feature-policy.sub.https.html
Accept-CH header test: FAIL (Chrome: FAIL, Safari: FAIL)
Cross-Origin Accept-CH header test: FAIL (Chrome: FAIL, Safari: FAIL)
/client-hints/accept-ch-no-feature-policy-navigation.https.html
Client hints not loaded on cross-origin iframe request with no feature policy.: FAIL (Chrome: PASS, Safari: FAIL)
Client hints loaded on same-origin iframe request with no feature policy.: FAIL (Chrome: FAIL, Safari: FAIL)
Client hints loaded on cross-origin iframe request with allow list.: FAIL (Chrome: FAIL, Safari: FAIL)
Client hints loaded on same-origin iframe request with allow list.: FAIL (Chrome: FAIL, Safari: FAIL)
/client-hints/accept-ch-no-feature-policy.sub.https.html
Accept-CH header test: FAIL (Chrome: FAIL, Safari: FAIL)
/client-hints/http-equiv-accept-ch-merge.https.html
Accept-CH header test: FAIL (Chrome: FAIL, Safari: FAIL)
/client-hints/service-workers/intercept-request.https.html
Service workers succsefully receives hints from request: FAIL (Chrome: FAIL, Safari: TIMEOUT)
/client-hints/service-workers/navigation-preload-critical.https.window.html
Service worker successfully passes hints through to new fetch: FAIL (Chrome: FAIL, Safari: TIMEOUT)
/client-hints/service-workers/navigation-preload.https.html
Service worker successfully passes hints through to new fetch: FAIL (Chrome: FAIL, Safari: TIMEOUT)
/client-hints/service-workers/passthrough-request-critical.https.window.html
Service worker successfully passes hints through to new fetch: FAIL (Chrome: FAIL, Safari: TIMEOUT)
/client-hints/service-workers/passthrough-request.https.html
Service worker successfully passes hints through to new fetch: FAIL (Chrome: FAIL, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ba5a7725b250 [wpt PR 31216] - [Legacy client hints modernization] (5) Check for `sec-ch-` in WebTests, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.