request flags should use a #define instead of masking w/ 0xffff

RESOLVED FIXED

Status

()

Core
Networking
--
minor
RESOLVED FIXED
15 years ago
6 years ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

15 years ago
In several places (imgLoader.cpp, nsLoadGroup.cpp, etc) there is code that masks
requestflags with 0xFFFF to separate the low 16 bits from the top 16 used by
subclasses.  This should be a #define, as per our discussion in IRC.

Updated

15 years ago
Status: NEW → ASSIGNED
Priority: -- → P5
Target Milestone: --- → mozilla1.3alpha

Updated

15 years ago
Target Milestone: mozilla1.3alpha → Future

Comment 1

11 years ago
-> default owner
Assignee: darin → nobody
Status: ASSIGNED → NEW
QA Contact: benc → networking
Target Milestone: Future → ---
Priority: P5 → --
(Assignee)

Comment 2

6 years ago
Created attachment 537732 [details] [diff] [review]
Simple fix

Turns out the hard constant 0xFFFF was still sitting in imgLoader.cpp and nsLoadGroup.cpp 9 years later...

Simple fix.  It doesn't appear to be elsewhere, other than those two files.

Guessing from r= in imgLoader.cpp that Joe Drew is appropriate for review.
Assignee: nobody → rjesup
Status: NEW → ASSIGNED
Attachment #537732 - Flags: review?(joe)
(Assignee)

Updated

6 years ago
Attachment #537732 - Flags: review?(joe) → review?(cbiesinger)
Attachment #537732 - Flags: review?(cbiesinger) → review+
(Assignee)

Comment 3

6 years ago
Checked in: http://hg.mozilla.org/mozilla-central/rev/26a8cb097609
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Attachment #537732 - Flags: checkin+
You need to log in before you can comment on or make changes to this bug.