Closed
Bug 173561
Opened 23 years ago
Closed 14 years ago
request flags should use a #define instead of masking w/ 0xffff
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jesup, Assigned: jesup)
Details
Attachments
(1 file)
|
2.48 KB,
patch
|
Biesinger
:
review+
jesup
:
checkin+
|
Details | Diff | Splinter Review |
In several places (imgLoader.cpp, nsLoadGroup.cpp, etc) there is code that masks
requestflags with 0xFFFF to separate the low 16 bits from the top 16 used by
subclasses. This should be a #define, as per our discussion in IRC.
|
||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P5
Target Milestone: --- → mozilla1.3alpha
|
|
||
Updated•23 years ago
|
Target Milestone: mozilla1.3alpha → Future
|
|
||
Comment 1•19 years ago
|
||
-> default owner
Assignee: darin → nobody
Status: ASSIGNED → NEW
QA Contact: benc → networking
Target Milestone: Future → ---
|
||
Updated•19 years ago
|
Priority: P5 → --
|
Assignee | |
Comment 2•14 years ago
|
||
Turns out the hard constant 0xFFFF was still sitting in imgLoader.cpp and nsLoadGroup.cpp 9 years later...
Simple fix. It doesn't appear to be elsewhere, other than those two files.
Guessing from r= in imgLoader.cpp that Joe Drew is appropriate for review.
|
|
Assignee | |
Updated•14 years ago
|
Attachment #537732 -
Flags: review?(joe) → review?(cbiesinger)
|
|
||
Updated•14 years ago
|
Attachment #537732 -
Flags: review?(cbiesinger) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•14 years ago
|
Attachment #537732 -
Flags: checkin+
You need to log in
before you can comment on or make changes to this bug.
Description
•