Closed Bug 1735659 Opened 3 years ago Closed 3 years ago

Make sure ReadableStreams are correctly integrated into Memory Reporting

Categories

(Core :: DOM: Streams, task, P3)

Product:
Core
Component:
DOM: Streams
Type:
task

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: mgaudet, Unassigned)

References

(Blocks 1 open bug)

Details

i.e. do we need to implement SizeOfIncludingThis etc?

Olli: This is mostly a question of how to test / check this and what needs to be validated: Any suggestions?

Severity: -- → S3
Flags: needinfo?(bugs)
Priority: -- → P3

The way to validate a memory reporter is to use DMD mode: https://firefox-source-docs.mozilla.org/xpcom/dmd.html

Normal Nightly builds are already DMD enabled, so you shouldn't need to change the build flags, just runtime flags.

You'll do something like start Firefox with DMD enabled, open a page that uses streams, save a memory report, then look at the DMD report and see if there's streams-related stuff that is under- or over-reported.

Flags: needinfo?(bugs)

Ran DMD on a Streams build while running one of the streams demos. No Streams related classes were reported by DMD, so I'm calling this resolved.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.