1735663 - Audit Error Messages, and make sure they're on par with JS Streams implementation

Status: RESOLVED FIXED

(Core :: DOM: Streams, task)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

We need to audit our Error messages and make sure that they're approximately on par with the JS Streams implementation.

(Mildly concerned we need to make sure we match them for compat reasons, but, 🤞🏻)

Comment 1

[Tom S [:evilpie]]

We definitely need to make some improvements to our error messages. We are worse than our old implementation and Chrome.

As an example:

new ReadableStream({ start(controller) { controller.close(); controller.close() } })
Firefox old: 'close' called on a stream already closing.
Chrome: Failed to execute 'close' on 'ReadableStreamDefaultController': Cannot close a readable stream that has already been requested to be closed
Firefox new: ReadableStreamDefaultController.close: Cannot Close

var stream = new ReadableStream(); stream.getReader(); new ReadableStreamDefaultReader(stream);
Firefox old: n/a (no ReadableStreamDefaultReader)
Chrome: Failed to construct 'ReadableStreamDefaultReader': ReadableStreamDefaultReader constructor can only accept readable streams that are not yet locked to a reader
Firefox new: ReadableStreamDefaultReader constructor: Stream is Locked

Comment 2

[Tom S [:evilpie]]

Attachment: Bug 1735663 - Improve ReadableStream.cancel error message. r?mgaudet

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/765503830af8
Improve ReadableStream.cancel error message. r=mgaudet

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/765503830af8

Comment 5

[Tom S [:evilpie]]

Attachment: Bug 1735663 - Improve error messages for ReadableStreamDefaultController. r?mgaudet

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e26bf5b90433
Improve error messages for ReadableStreamDefaultController. r=mgaudet

Comment 7

[Tom S [:evilpie]]

Attachment: Bug 1735663 - Improve error messages for ReadableStream reader. r?mgaudet

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e26bf5b90433

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc74f768d0eb
Improve error messages for ReadableStream reader. r=mgaudet

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/cc74f768d0eb

Comment 11

[Tom S [:evilpie]]

All readable streams (excluding byte streams) error messages should now be in a good place. We can open a new bug for code we don't plan on shipping first.