1735664 - Implement WritableStream

Status: RESOLVED FIXED

(Core :: DOM: Streams, task)

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1735664 - Implement the WritableStream APIs. r?smaug!,mgaudet

This implements many of the basic algorithms required to get WritableStreams working.
Most notably everything related to abort is missing.

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1735664 - Introduce GlobalNames::PaintWorkletGlobalScope. r?smaug!

I got errors about this thing missing after adding some partial interface without Worklet.

Comment 3

[Tom S. (please needinfo tschuster)]

The implementation is now complete. We are passing all WPT stream/writable-stream tests except something related to the unimplemented ByteLengthQueuingStrategy. I probably still need some time to get this buildable without unified builds though.

I am also surprised that WritableStreamDefaultController seem to work without null-checking GetController following the specification to the letter, considering that releaseLock can actually unset mStream. I need to convince myself that is correct. (Especially SinkCloseNativePromiseHandler)

Comment 5

[Tom S. (please needinfo tschuster)]

I am also surprised that WritableStreamDefaultController seem to work without null-checking GetStream (not GetController) following the specification to the letter, considering that releaseLock can actually unset mStream. I need to convince myself that is correct. (Especially SinkCloseNativePromiseHandler)

I confused myself a little bit here. The DefaultController has a strong reference to the stream that can never be unset. I actually changed the code now to make this less likely. releaseLock is only relevant to the stream in DefaultWriter ..

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfb1c3b5cd6d
Introduce GlobalNames::PaintWorkletGlobalScope. r=smaug

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/dfb1c3b5cd6d

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e56ff0301f6
Implement the WritableStream APIs. r=mgaudet,smaug

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5e56ff0301f6