1735769 - [wpt-sync] Sync PR 31233 - Remove the `test_obj` parameter from the structured clone tests

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 31233 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31233
Details from upstream follow.

Andreu Botella <[e-mail]> wrote:

Remove the test_obj parameter from the structured clone tests

The test_obj parameter in the comparison functions of the structured clone battery of tests doesn't seem to be used at all, considering that the those functions only use it to call test_obj.done(), which is a no-op. This seems to have once been used to indicate asynchronous test completion, but that hasn't worked for a long time, and #31232 has now made that obsolete.

Aside from removing the test_obj arguments to the comparison functions and the calls to test_obj.done(), as well as the creation of the testObjMock object in the check function, this change also removes the callback_is_async boolean argument to compare_Array and compare_Object.

---

This PR depends on #31232.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 31233 applied with additional changes from upstream: a90395d53081e4126ca88233e71127bb993515f3

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf87a77dd969623d5d25d5aa54c2bbac6a924733

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 130 subtests

Status Summary

Firefox

OK : 9
PASS : 1101
PRECONDITION_FAILED: 9

Chrome

OK : 9
PASS : 858
FAIL : 252

Safari

OK : 7
PASS : 580
FAIL : 280
PRECONDITION_FAILED: 5
ERROR : 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/infrastructure/safe-passing-of-structured-data/messagechannel.any.html
A subclass instance will be received as its closest transferable superclass: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/html/infrastructure/safe-passing-of-structured-data/messagechannel.any.worker.html
A subclass instance will be received as its closest transferable superclass: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/html/infrastructure/safe-passing-of-structured-data/messagechannel.any.serviceworker.html
A subclass instance will be received as its closest transferable superclass: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/html/infrastructure/safe-passing-of-structured-data/messagechannel.any.sharedworker.html
A subclass instance will be received as its closest transferable superclass: PRECONDITION_FAILED (Chrome: PASS)
/html/infrastructure/safe-passing-of-structured-data/window-postmessage.window.html
A subclass instance will be received as its closest transferable superclass: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/html/webappapis/structured-clone/structured-clone.any.worker.html
A subclass instance will be received as its closest transferable superclass: PRECONDITION_FAILED (Chrome: FAIL, Safari: FAIL)
/html/webappapis/structured-clone/structured-clone.any.html
A subclass instance will be received as its closest transferable superclass: PRECONDITION_FAILED (Chrome: FAIL, Safari: FAIL)
/workers/semantics/structured-clone/dedicated.html
A subclass instance will be received as its closest transferable superclass: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/workers/semantics/structured-clone/shared.html
A subclass instance will be received as its closest transferable superclass: PRECONDITION_FAILED (Chrome: PASS)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37e7c1acd641
[wpt PR 31233] - Remove the `test_obj` parameter from the structured clone tests, a=testonly

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/37e7c1acd641