1735815 - support crash annotation XPCOMSpinEventLoopStack field

Status: RESOLVED FIXED

(Socorro :: General, task, P2)

Description

[Jens Stutte [:jstutte]]

Please

• make it searchable in supersearch
• make it aggregatable in supersearch

Thanks you

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Did this field undergo data collection review? If so, what was the bug for that?

Comment 2

[Jens Stutte [:jstutte]]

Yes: bug 1678330.
There is an additional review requested in bug 1735129 as we are adding the thread name.

Comment 3

[Jens Stutte [:jstutte]]

(your signature says to ni you)

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

In both data reviews, the question "Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way." doesn't answer what the data looks like or where it's documented.

What do the values look like?

Comment 5

[Jens Stutte [:jstutte]]

The values are currently literal strings, see the uses of SpinEventLoopUntil, containing an identifier that can be easily traced in the source (most of the times similar to the containing function's name but with no formal requirements).

The new use wants to add the thread's name for one specific instance only.

Comment 6

[Jens Stutte [:jstutte]]

I should add, that we can see a concatenation of those strings in XPCOMSpinEventLoopStack if we are in a nested event loop situation (without newlines).

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Ok. Looks like it's a finite low-cardinality set of keywords. I'll index it that way.

I'll try to get to this in the next week.

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5880: bug 1735815: add XPCOMSpinEventLoopStack to index

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5880: "bug 1735815: add XPCOMSpinEventLoopStack to index" in 8e2b1f7.

Comment 10

[Will Kahn-Greene [:willkg] ET needinfo? me]

I pushed this to prod today in bug #1738043.

A new index will get built this weekend with the new field in it. After that, this field will be searchable. I'll keep it open to verify.

Comment 11

[Jens Stutte [:jstutte]]

Great, thanks!

Comment 12

[Will Kahn-Greene [:willkg] ET needinfo? me]

A new index was created and the field is now being added to it. I can facet and search on it. Marking as FIXED.