Closed Bug 1735860 Opened 3 years ago Closed 3 years ago

A11y Followup - step indicator var & colorways selector variations in HCM

Categories

(Firefox :: Messaging System, defect, P2)

Product:
Firefox
Component:
Messaging System
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
95 Branch
Iteration:
95.2 - Oct 18 - Oct 31
Project Flags:
Accessibility Severity s3
Tracking Flags:
Tracking Status
firefox94 --- wontfix
firefox95 --- verified

People

(Reporter: emcminn, Assigned: emcminn)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [hcm-2021-h2])

Attachments

(2 files)

high contrast white build 20211014093415
85.58 KB, image/jpeg
Details
Bug 1735860 - Change step indicator var to work with Dark themes in HCM, adjust theme varation buttons to match HCM colors
48 bytes, text/x-phabricator-request
Details | Review

A small patch to address QA feedback on https://bugzilla.mozilla.org/show_bug.cgi?id=1733690

Assignee: nobody → emcminn

The designs for bug 1733690 also seem to make the step indicators empty vs filled for better high contrast. But that wasn't implemented in the original accessibility fix bug? Is that getting addressed here?

https://www.figma.com/file/blhdnzQOhWYKcdiCzywMuG/MR2-Onboarding?node-id=1163%3A99937

Blocks: 1728848
Severity: -- → S3
Priority: -- → P2

We can try to address in Fx95, but not crucial for the 94 release.

Iteration: --- → 95.1 - Oct 4 - Oct 17
status-firefox94: --- → wontfix
status-firefox95: --- → affected

(In reply to Ed Lee :Mardak from comment #1)

The designs for bug 1733690 also seem to make the step indicators empty vs filled for better high contrast. But that wasn't implemented in the original accessibility fix bug? Is that getting addressed here?

https://www.figma.com/file/blhdnzQOhWYKcdiCzywMuG/MR2-Onboarding?node-id=1163%3A99937

We had the hollow step indicators in a previous version of about:welcome and moved away from them because they were getting distorted at certain resolutions & zoom levels - since we're aiming this for 95 now I'll check back with UI before I submit the patch.

Iteration: 95.1 - Oct 4 - Oct 17 → 95.2 - Oct 18 - Oct 31
Whiteboard: [access-s3][hcm-2021-h2]
Keywords: access
Pushed by emcminn@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ab50105bdce2
Change step indicator var to work with Dark themes in HCM, adjust theme varation buttons to match HCM colors r=pdahiya

https://hg.mozilla.org/mozilla-central/rev/ab50105bdce2

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

Marking this issue as verified based on the verification done and mentioned in bug 1733690.

Status: RESOLVED → VERIFIED
status-firefox95: fixed → verified
Flags: qe-verify+
Accessibility Severity: --- → s3
Whiteboard: [access-s3][hcm-2021-h2] → [hcm-2021-h2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: