1735875 - ServiceWorker-controlled pages losing their controller after going into and coming out of BFCache due to dropped ClientHandle actors on freeze

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect, P3)

Description

[Andrew Sutherland [:asuth] (he/him)]

In https://github.com/w3c/ServiceWorker/issues/1594#issuecomment-942933128 it was identified that "on Firefox, after a page is restored from BFCache, the page seems uncontrolled by service workers (even if it was controlled before BFCached). Is this a known issue". This is from tests being developed as part of https://github.com/web-platform-tests/wpt/pull/31082.

Comment 1

[Olli Pettay [:smaug][[e-mail]](vacation until Nov 16)]

the tests pass if I comment out https://searchfox.org/mozilla-central/rev/0ec81de2037cb0a0701d5d316f42763230b3a142/dom/clients/manager/ClientSourceParent.cpp#124-126

We're missing to recreate the handles somewhere or should not delete them at all (only mark frozen)?

Comment 2

[Olli Pettay [:smaug][[e-mail]](vacation until Nov 16)]

Attachment: Bug 1735875, ServiceWorkers + bfcache: evict bfcache in certain cases, to pass the existing WPTs, and add a new test for Client.postMessage, r=asuth

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/249823eb1a68
ServiceWorkers + bfcache: evict bfcache in certain cases, to pass the existing WPTs, and add a new test for Client.postMessage, r=asuth

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34446 for changes under testing/web-platform/tests

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/249823eb1a68

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging