Closed Bug 1736034 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31268 - Change wpt tests for <meta name=color-scheme> as per https://github.com/whatwg/html/pull/7226

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31268 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31268
Details from upstream follow.

Emilio Cobos Álvarez <emilio@crisal.io> wrote:

Change wpt tests for <meta name=color-scheme> as per https://github.com/whatwg/html/pull/7226

This makes the assumption that the initial browser's color-scheme is
light, which I think is a reasonable assumption to run these tests
under.

An alternative would have to allow both "light" and "dark" wherever we
check for "normal" now (which loses test coverage in practice), or I
could complicate the test to compute the initial color-scheme using an
iframe or what not (but that complicates everything more).

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 11 tests and 1 subtests

Status Summary

Firefox

OK : 11
FAIL: 23

Chrome

OK : 11
PASS: 23

Safari

OK : 11
PASS: 17
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-attribute-changes.html
Meta color-scheme initially 'dark'.: FAIL linked bug:Bug 1667168
Set meta name to color-scheme.: FAIL linked bug:Bug 1667168
Set content attribute of meta color-scheme to empty string.: FAIL linked bug:Bug 1667168
Set content attribute of meta color-scheme to an invalid value.: FAIL linked bug:Bug 1667168
Set content attribute of meta color-scheme to 'light'.: FAIL linked bug:Bug 1667168
Set content attribute of meta color-scheme to 'dark'.: FAIL
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-empty-content-value.html
Meta color-scheme with empty content attribute has no effect.: FAIL linked bug:Bug 1667168
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-insert.html
Initial color-scheme: FAIL linked bug:Bug 1667168
Inserted meta color-scheme applies: FAIL linked bug:Bug 1667168
Inserted meta color-scheme before existing in head applies: FAIL linked bug:Bug 1667168
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-no-content-value.html
Meta color-scheme without content attribute has no effect.: FAIL linked bug:Bug 1667168
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-presentational-hint.html
Author origin style rule overrides meta color-scheme.: FAIL linked bug:Bug 1667168
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-remove-head.html
Meta color-scheme applies.: FAIL linked bug:Bug 1667168
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-remove.html
Second meta applies after first one is removed.: FAIL linked bug:Bug 1667168
Initial color-scheme with both meta elements removed.: FAIL linked bug:Bug 1667168
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-single-value-in-body.html
Meta color-scheme in body should apply.: FAIL
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-single-value-in-head.html
Meta color-scheme in head applies.: FAIL linked bug:Bug 1667168

New Tests That Don't Pass

/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-attribute-changes.html
Meta color-scheme initially 'dark'.: FAIL (Chrome: PASS, Safari: PASS)
Removed name attribute from meta color-scheme.: FAIL (Chrome: PASS, Safari: FAIL)
Set meta name to color-scheme.: FAIL (Chrome: PASS, Safari: PASS)
Set content attribute of meta color-scheme to empty string.: FAIL (Chrome: PASS, Safari: PASS)
Set content attribute of meta color-scheme to an invalid value.: FAIL (Chrome: PASS, Safari: PASS)
Set content attribute of meta color-scheme to 'light'.: FAIL (Chrome: PASS, Safari: PASS)
Set content attribute of meta color-scheme to 'dark'.: FAIL (Chrome: PASS, Safari: PASS)
Removed the content attribute of meta color-scheme.: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-empty-content-value.html
Meta color-scheme with empty content attribute has no effect.: FAIL (Chrome: PASS, Safari: PASS)
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-first-valid-applies.html
Tree order decides which meta color-scheme applies.: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-insert.html
Initial color-scheme: FAIL (Chrome: PASS, Safari: PASS)
Inserted meta color-scheme applies: FAIL (Chrome: PASS, Safari: PASS)
Inserted meta color-scheme before existing in head applies: FAIL (Chrome: PASS, Safari: PASS)
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-no-content-value.html
Meta color-scheme without content attribute has no effect.: FAIL (Chrome: PASS, Safari: PASS)
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-presentational-hint.html
Author origin style rule overrides meta color-scheme.: FAIL (Chrome: PASS, Safari: PASS)
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-remove-head.html
Meta color-scheme applies.: FAIL (Chrome: PASS, Safari: PASS)
Initial value after removing head including meta color-scheme.: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-remove.html
First meta applies.: FAIL (Chrome: PASS, Safari: FAIL)
Second meta applies after first one is removed.: FAIL (Chrome: PASS, Safari: PASS)
Initial color-scheme with both meta elements removed.: FAIL (Chrome: PASS, Safari: PASS)
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-single-value-in-body.html
Meta color-scheme in body should apply.: FAIL (Chrome: PASS, Safari: PASS)
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-single-value-in-head.html
Meta color-scheme in head applies.: FAIL (Chrome: PASS, Safari: PASS)
/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-single-value-in-shadow-tree.html
Meta color-scheme in shadow tree does not apply.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fae26bf55f8a [wpt PR 31268] - Change wpt tests for <meta name=color-scheme> to not depend on the color-scheme computed value (before whatwg/html#7226), a=testonly https://hg.mozilla.org/integration/autoland/rev/828b1a243a9f [wpt PR 31268] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/fae26bf55f8a
https://hg.mozilla.org/mozilla-central/rev/828b1a243a9f

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.